search

Clikengo / foundationdb-rs

FoundationDB Rust client api
Apache License 2.0
155 stars 29 forks source link

Add support for 7.x #180

Open Daniel-B-Smith opened 4 years ago

Daniel-B-Smith commented 4 years ago

Opening an issue since I'm about to start working on this and to get feedback before any PRs are sent out.

It looks like there are a couple of pieces added to the C API in 7.0: https://github.com/apple/foundationdb/issues/2644 The change to keyvalue from void* to uint8_t* made it in, so that may require a change to the generated interface. I'm actively working on https://github.com/apple/foundationdb/issues/2644, but that probably won't make it in until 7.1.

Speedy37 commented 4 years ago

The change to keyvalue from void to uint8_t made it in, so that may require a change to the generated interface.

I just made a change to prevent issues related to this: https://github.com/Clikengo/foundationdb-rs/pull/179/commits/129a688136d9e32584db3879559215eeb33fbe27

We are generating both options.rs and foundationdb_sys from fdb.options and fdb_cli.h so we should already be quite safe to catch any breaking change at compile time.

Daniel-B-Smith commented 4 years ago

That's great. All of the other changes to the C API should be strictly additive.

PierreZ commented 3 years ago

Are you working on this feature @Daniel-B-Smith? I just pushed a PR for 6.3, and I was thinking about doing 7.X next.

Daniel-B-Smith commented 3 years ago

I am not.

PierreZ commented 3 years ago

Okay, I will try to open a 7.X PR once a pre-release is tagged.

PierreZ commented 2 years ago

Initial work around api 700 can be found here