Closed rajeeja closed 3 years ago
You should probably squash the commits. The commit history here adds no value
Thanks for getting the linux action working @rajeeja . We can get osx as well later. This at least gives a basic regression checking mechanism for new commits. @paullric
@paullric you can run the regression tests locally on your mac using
cd regression_tests python regression_tests
A README file here: https://github.com/ClimateGlobalChange/tempestremap/tree/master/regression_tests has more info about the regression tests.
Also, manual.yml can be invoked by using the "Actions" tab, selected manual workflow and click on "Run workflow" on the right side selecting the branch.
The failed workflow run (https://github.com/ClimateGlobalChange/tempestremap/actions/runs/1318713485) is due to the old version of yml file, if you merge master to your branch, this error can go away.
@vijaysm for OSX, while running regression, libnetcdf is not found even after setting DYLD_LIBRARY_PATH - https://github.com/rajeeja/tempestremap/runs/3840964535?check_suite_focus=true#step:10:54 https://github.com/rajeeja/tempestremap/runs/3840964535?check_suite_focus=true#step:10:226
if we fix it, both osx and ubuntu can be a matrix for manual.yml, uncommenting this line: https://github.com/ClimateGlobalChange/tempestremap/blob/master/.github/workflows/manual.yml#L22
I have a few fixes on my fork, but was looking to get osx working before creating a PR.
Please provide any feedback you might have for improvements.
o Manual action works with ubuntu latest, it uses miniconda dependencies o Automatic action is for ubuntu with ubuntu dependencies o baseline pickle file with times averaged over 5 runs are added o timing data is available as a pickle file. todo: publish reg results and timing to a file