update DTR validation to include data type and different min validati…

ClimateImpactLab / dodola

Containerized application for running individual tasks in a larger, orchestrated CMIP6 bias-adjustment and downscaling workflow.

https://climateimpactlab.github.io/dodola/

Apache License 2.0

14 stars 7 forks source link

update DTR validation to include data type and different min validati… #155

Closed dgergel closed 2 years ago

dgergel commented 2 years ago

This PR updates DTR validation to differentiate bw CMIP6 and bias corrected/downscaled allowed min values. This is because CMIP6 data, before applying the DTR small values "correction", may have zero values if tasmin > tasmax and those have been swapped.

Also cleaned up a bit of other DTR validation in this one.

addresses this GFDL DTR run bug: https://github.com/ClimateImpactLab/downscaleCMIP6/issues/452

brews commented 2 years ago

Note, we're going to have to accommodate these changes in https://raw.githubusercontent.com/ClimateImpactLab/downscaleCMIP6/master/workflows/templates/qualitycontrol-check-cmip6.yaml -- this PR will break this Workflow.

dgergel commented 2 years ago

thanks @brews - merging now.