ClimateImpactLab / dodola

Containerized application for running individual tasks in a larger, orchestrated CMIP6 bias-adjustment and downscaling workflow.
https://climateimpactlab.github.io/dodola/
Apache License 2.0
14 stars 7 forks source link

Corrected DTR ceiling #165

Closed emileten closed 2 years ago

emileten commented 2 years ago

This corrects a mistake introduced by https://github.com/ClimateImpactLab/dodola/pull/163. The functionality to cap non-polar DTR values had an error in its implementation that lead all polar values to be modified. The tests couldn't catch this because they were also wrong, using == to compare xarray.Dataset objects.

This PR :

brews commented 2 years ago

When this merges @emileten, do you want to take this for a test with dodola:dev on larger data or should we turn around a new patched release?

emileten commented 2 years ago

@brews thanks for the review. I'd like to test it first with dev.