ClimateImpactLab / dodola

Containerized application for running individual tasks in a larger, orchestrated CMIP6 bias-adjustment and downscaling workflow.
https://climateimpactlab.github.io/dodola/
Apache License 2.0
14 stars 7 forks source link

corrected DTR ceiling boolean expression and tests accordingly #166

Closed emileten closed 2 years ago

emileten commented 2 years ago

This corrects a bug introduced by https://github.com/ClimateImpactLab/dodola/pull/165.

In the DTR ceiling we were making use of direct comparison operators like or etc... Which lead to a typical error with arrays.

This was not caught by the tests because there was only one latitude coordinate.

Changes :

I am not doing anything to the changelog because this is just an extension of #165.

brews commented 2 years ago

Wicked. Thanks @emileten. Appreciate you updating the test for this. That's the right move.

Your instinct about not adding a new CHANGELOG entry for this is correct, instead, just add this PR to the existing entry. I added this for you in 20e923ea4d93020f5cc6eef6003e66841818b9e7.

emileten commented 2 years ago

Thanks for doing that @brews.