Closed emileten closed 2 years ago
Wicked. Thanks @emileten. Appreciate you updating the test for this. That's the right move.
Your instinct about not adding a new CHANGELOG entry for this is correct, instead, just add this PR to the existing entry. I added this for you in 20e923ea4d93020f5cc6eef6003e66841818b9e7.
Thanks for doing that @brews.
This corrects a bug introduced by https://github.com/ClimateImpactLab/dodola/pull/165.
In the DTR ceiling we were making use of direct comparison operators like
or
etc... Which lead to a typical error with arrays.This was not caught by the tests because there was only one latitude coordinate.
Changes :
xr.ufuncs
logical operatorsI am not doing anything to the changelog because this is just an extension of #165.