search

ClimateImpactLab / dodola

Containerized application for running individual tasks in a larger, orchestrated CMIP6 bias-adjustment and downscaling workflow.
https://climateimpactlab.github.io/dodola/
Apache License 2.0
16 stars 8 forks source link

drop spatial bounds coordinates if present in cmip6 cleaning #177

Closed emileten closed 2 years ago

emileten commented 2 years ago

The presence of coordinates values associated with the spatial bounds dimension can cause errors downstream, in particular when doing distributed regridding. We have an example of this kind of problem in the above linked issue.

Since the libraries we use do not need this information -- these libraries have been doing their job correctly when exposed to datasets that do not have these coordinates -- I decided to simply drop this information in cleaning.

This only drops the coordinates, not the dimension, which we need.

emileten commented 2 years ago

I haven't tested this in an actual workflow. I checked this in a notebook.

I was hoping to merge this in master to be able to test it in a workflow using dodola:dev, so as to avoid convoluted workflow manipulation.

@brews could you have a look ? Let me know if you see any problem with this change. Thank you !

brews commented 2 years ago

Thanks for making progress on this, @emileten!

As I look at this, I see there might actually be a better way around this back in the regridding workflowtemplate... let me try something and I'll follow up here or in https://github.com/ClimateImpactLab/downscaleCMIP6/issues/494

brews commented 2 years ago

I'm going to close this because I think we resolved this problem elsewhere. Please reopen or file a new issue if still needed.