search

ClimateImpactLab / dodola

Containerized application for running individual tasks in a larger, orchestrated CMIP6 bias-adjustment and downscaling workflow.
https://climateimpactlab.github.io/dodola/
Apache License 2.0
14 stars 7 forks source link

Fix broken pint use in xclim #214

Closed brews closed 1 year ago

brews commented 1 year ago

xclim has recently failed to import pint.unit in CI tests. Pinning to earlier version of pint (pint < 0.20.0) sub-dependency to work around this without radically changing how we handle dependencies and environment builds.

Examples of this failure: https://github.com/ClimateImpactLab/dodola/actions/runs/3410997828/jobs/5674649890 https://github.com/ClimateImpactLab/dodola/actions/runs/3322139201/jobs/5490744399 from PR #212 and PR #213.

I don't think this will change the way the package runs. This is an internal maintenance thing.

brews commented 1 year ago

Ugg, this is a sign we should start using proper .lock files for the conda environment.

codecov-commenter commented 1 year ago

Codecov Report

Merging #214 (b6957f0) into main (a60898c) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #214   +/-   ##
=======================================
  Coverage   89.34%   89.34%           
=======================================
  Files           8        8           
  Lines        1352     1352           
=======================================
  Hits         1208     1208           
  Misses        144      144

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more