search

ClimateImpactLab / dodola

Containerized application for running individual tasks in a larger, orchestrated CMIP6 bias-adjustment and downscaling workflow.
https://climateimpactlab.github.io/dodola/
Apache License 2.0
16 stars 8 forks source link

Fix broken env from esmf/xesmf #222

Closed brews closed 1 year ago

brews commented 1 year ago

Add and pin esmf to environment file. Pinning it to version just before it breaks compatibility with the version of xesmf we're running.

Considering conda-lock.

[summarize your pull request here]

codecov-commenter commented 1 year ago

Codecov Report

Merging #222 (ef5f780) into main (2123d31) will not change coverage. The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #222   +/-   ##
=======================================
  Coverage   89.34%   89.34%           
=======================================
  Files           8        8           
  Lines        1352     1352           
=======================================
  Hits         1208     1208           
  Misses        144      144

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

brews commented 1 year ago

Ok, this looks good to merge because we've removed the environment issue with xesmf and ESMF. This new codequality failure in CI is due to recent style changes in `black'. This is a problem for another PR.