ClimateImpactLab / downscaleCMIP6

Downscaling & bias correction of CMIP6 tasmin, tasmax, and pr for the R/CIL GDPCIR project
MIT License
129 stars 31 forks source link

ACCESS-ESM1 e2e tasmin run fails due to out of range values pre-QDM #510

Closed emileten closed 2 years ago

emileten commented 2 years ago

Workflow : https://argo.cildc6.org/workflows/default/e2e-access-esm1-5-tasmin-n44gb?tab=workflow&nodeId=e2e-access-esm1-5-tasmin-n44gb-850271634&nodePanelView=inputs-outputs

Log :

Validating gs://clean-b1dbca25/cmip6/CMIP/CSIRO/ACCESS-ESM1-5/historical/r1i1p1f1/day/tasmin/gn/v20191115.zarr
Traceback (most recent call last):
  File "/argo/staging/script", line 47, in <module>
    tasks = dask.compute(*tasks)
  File "/opt/conda/lib/python3.9/site-packages/dask/base.py", line 570, in compute
    results = schedule(dsk, keys, **kwargs)
  File "/opt/conda/lib/python3.9/site-packages/dask/threaded.py", line 79, in get
    results = get_async(
  File "/opt/conda/lib/python3.9/site-packages/dask/local.py", line 507, in get_async
    raise_exception(exc, tb)
  File "/opt/conda/lib/python3.9/site-packages/dask/local.py", line 315, in reraise
    raise exc
  File "/opt/conda/lib/python3.9/site-packages/dask/local.py", line 220, in execute_task
    result = _execute_task(task, data)
  File "/opt/conda/lib/python3.9/site-packages/dask/core.py", line 119, in _execute_task
    return func(*(_execute_task(a, cache) for a in args))
  File "/argo/staging/script", line 32, in clear_memory_intensive_tests
    _test_temp_range(d, v)
  File "/opt/dodola/dodola/core.py", line 751, in _test_temp_range
    assert (ds[var].min() > 150) and (
AssertionError: tasmin values are invalid

This file is the clean GCM data. Diving into it, the culprit is one data point in Greenland that's around -130C :

Screen Shot 2022-01-17 at 11 09 20 AM

This is the only data point below our current tolerance window (150 K, 360 K), furthermore, while there are data points between [150 K, 200 K] those are relatively rare and all where it should be observed (Antarctica).

This is historical. The ssp files all passed validation.

emileten commented 2 years ago

https://github.com/ClimateImpactLab/dodola/pull/170 solved this, which I verified in a test qualitycontrol run https://argo.cildc6.org/workflows/default/qualitycontrol-check-cmip6-dev-96mqt?tab=workflow.