ClimateImpactLab / downscaleCMIP6

Downscaling & bias correction of CMIP6 tasmin, tasmax, and pr for the R/CIL GDPCIR project
MIT License
136 stars 33 forks source link

Simplify QC workflow replacing script with dodola v0.18.0 command #590

Closed brews closed 2 years ago

brews commented 2 years ago

This simply swaps an argo-nested script for the simpler dodola command.

We couldn't do this in dodola releases before v0.18.0 because of memory issues resolved in this release.

[summarize your pull request here]

brews commented 2 years ago

I tested this update manually, here: https://argo.cildc6.org/workflows/default/qualitycontrol-check-cmip6-test-5kckg

Edit: That fails the data. Here is another test run on different data: https://argo.cildc6.org/workflows/default/qualitycontrol-check-cmip6-test-cvmhh

brews commented 2 years ago

@emileten when you have a minute, can you give this a quick check? Thank you for your help.

emileten commented 2 years ago

@brews the input which failed -- where did you pick the input path from ? I see that it's downscaled data. Making sure it's not our current output.

brews commented 2 years ago

Good question, @emileten. That's the default arguments to the QC workflowtemplate.

emileten commented 2 years ago

Ah I had dropped this, sorry @brews. I had just that question. It looks good otherwise !