ClimateImpactLab / downscaleCMIP6

Downscaling & bias correction of CMIP6 tasmin, tasmax, and pr for the R/CIL GDPCIR project
MIT License
136 stars 33 forks source link

Fix to failed to find unique target for patch #617

Closed brews closed 2 years ago

brews commented 2 years ago

Versions of Argo workflows after v3.3.4 appear to have a namespace added to their install.yaml resources (see https://github.com/argoproj/argo-workflows/pull/8280 and https://github.com/argoproj/argo-workflows/issues/8250#issuecomment-1084046919), with causes an error when kustomization tries to apply updates:

ComparisonError  rpc error: code = Unknown desc = Manifest generation error (cached): `kustomize build /tmp/https___github.com_climateimpactlab_downscalecmip6/infrastructure/kubernetes-gcp/argo` failed exit status 1: Error: no matches for Id ~G_v1_ConfigMap|~X|workflow-controller-configmap; failed to find unique target for patch ~G_v1_ConfigMap|workflow-controller-configmap  2022-06-02 18:16:15 -0700 PDT

This might relate to a bug in customization (see https://github.com/kubernetes-sigs/kustomize/issues/1332).

So we're specifying the namespace in the install.yaml resource when defining the patch for the customization with the hopes that it will be able to find its target.

[summarize your pull request here]

brews commented 2 years ago

Nope, this doesn't get it completely. Need to revert this and try something else.