search

ClimateImpactLab / downscaleCMIP6

Downscaling & bias correction of CMIP6 tasmin, tasmax, and pr for the R/CIL GDPCIR project
MIT License
136 stars 33 forks source link

Put target ns in strategic merge patch to ID patch target for argo service account #620

Closed brews closed 2 years ago

brews commented 2 years ago

Extension of fix from PR #617, PR #618, PR #619.

Applies a similar fix to the patchesStrategicMerge for argo-workflow's argo-server ServiceAccount. Apparently, kustomize can't find a unique target to apply the patch to after argo-workflows started hard coding the "argo" namespace in their install.yaml in >= v3.3.5.

In case anyone else has the problem, I found this after ArgoCD started reporting errors while syncing:

Message:            ComparisonError: rpc error: code = Unknown desc = `kustomize build /tmp/https___github.com_climateimpactlab_downscalecmip6/infrastructure/kubernetes-gcp/argo` failed exit status 1: Error: no matches for Id ~G_v1_ServiceAccount|~X|argo-server; failed to find unique target for patch ~G_v1_ServiceAccount|argo-server

This pops up after the upstream change from https://github.com/argoproj/argo-workflows/pull/8280. Had no issues with updates and deployments before this change.

brews commented 2 years ago

If this solves the last of these issues with the update, it might be worth dropping an issue with argo-workflows to let them know about the break. At the very least it might help people with the same breaks from applying the newer patches.