search

ClimateImpactLab / dscim

Data-Driven Spatial Climate Impact Model core component code
https://climateimpactlab.github.io/dscim/
Apache License 2.0
4 stars 2 forks source link

Upgrade CI Python version to >= 3.12 #270

Closed brews closed 3 months ago

brews commented 3 months ago

CI previously ran on Python 3.10. This upgrades it to 3.12.

Close #150

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.91%. Comparing base (8c3e7c5) to head (4e950d4).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #270 +/- ## ======================================= Coverage 68.91% 68.91% ======================================= Files 15 15 Lines 1750 1750 ======================================= Hits 1206 1206 Misses 544 544 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

brews commented 3 months ago

Heads up to @JMGilbert @kemccusker. It's good to test on a recent version of Python. Any concerns with running CI tests on Python 3.12?

kemccusker commented 3 months ago

Heads up to @JMGilbert @kemccusker. It's good to test on a recent version of Python. Any concerns with running CI tests on Python 3.12?

None that I can think of, except we may pin to earlier versions of python in calling applications, but those are also pinned to earlier versions of dscim so I think it's fine.

brews commented 3 months ago

Thanks, @kemccusker. To be clear this doesn't make Python >= 3.12 a requirement for users installing the package. It's just the Python version CI tests on.