discounting for non-standard dt

ClimateMARGO / ClimateMARGO.jl

Julia implementation of MARGO, an idealized climate-economic modelling framework for Optimizing trade-offs between emissions Mitigation, Adaptation, carbon dioxide Removal, and solar Geoengineering.

https://margo.plutojl.org/

MIT License

67 stars 13 forks source link

discounting for non-standard dt #16

Closed fonsp closed 4 years ago

hdrake commented 4 years ago

Thanks for catching this bug! I'll rerun the examples that used a non-standard dt (e.g. Replicate Belaia) and see if it affects the results at all.

fonsp commented 4 years ago

In my small experiments: before this fix, and before realising that domain and dt should be set to match each other, I was getting order-2 differences in the total control cost. Afterwards, I got very close results for different dts between 1 and 20!

hdrake commented 4 years ago

Good to know, thanks!