JuMP and Ipopt compat upgrade

ClimateMARGO / ClimateMARGO.jl

Julia implementation of MARGO, an idealized climate-economic modelling framework for Optimizing trade-offs between emissions Mitigation, Adaptation, carbon dioxide Removal, and solar Geoengineering.

https://margo.plutojl.org/

MIT License

67 stars 13 forks source link

JuMP and Ipopt compat upgrade #85

Closed fonsp closed 1 year ago

fonsp commented 1 year ago

Let's see if the tests pass

fonsp commented 1 year ago

Looks like the Ipopt version is still bound by another dependency: https://github.com/ClimateMARGO/ClimateMARGO.jl/actions/runs/3395776825/jobs/5646082485#step:4:61

fonsp commented 1 year ago

The latest test run passed with JuMP v1 and Ipopt v1, both at the latest versions! 🎉

Note that we have tests that pin the output of ClimateMARGO: https://github.com/ClimateMARGO/ClimateMARGO.jl/blob/32e66fd5e53ff2aca89b6e397f22b9855d5bcc40/test/runtests.jl#L36 This means that the JuMP and Ipopt upgrades did not change the output of ClimateMARGO, at least not for the functionality we test there.

hdrake commented 1 year ago

Wow, that's great news. Thanks for this update Fons!