ClimateMind / climatemind-backend

Your climate action is here 🌎 Our API is a source for learning how climate change personally affects you and the things you care about most. Additionally, it will teach a scientifically proven method for communicating to others that climate change is a personally relevant issue to inspire action.
https://contribute.climatemind.org/v/rest-api/
MIT License
18 stars 19 forks source link

393 replace cypress email tests with pytest and eliminate cypress #490

Closed cyplas closed 1 year ago

cyplas commented 1 year ago

Detailed information:

Replaced the cypress email e2e tests with pytest integration tests, as for the other e2e tests, and got rid of remaining cypress stuff in general.

Closing issues:

List all issues the pull request solve:

Test plan (required)

codecov-commenter commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (1e5462b) 74.30% compared to head (5a450ea) 74.30%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #490 +/- ## ======================================== Coverage 74.30% 74.30% ======================================== Files 85 85 Lines 2681 2681 Branches 315 315 ======================================== Hits 1992 1992 Misses 657 657 Partials 32 32 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ClimateMind). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ClimateMind)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

cyplas commented 1 year ago

@danmash Not surprisingly this PR is not passing the circleci cypress check. I'm guessing that the webhook just needs to be deleted (https://github.com/ClimateMind/climatemind-backend/settings/hooks), but I haven't used these before and don't want to make a mess. :)

cyplas commented 1 year ago

Also, I upgraded black (due to the otherwise failing lint test) and its dependencies click and packaging, but I see that click is also explicitly used in ontology processing: https://github.com/ClimateMind/climatemind-backend/blob/develop/app/ontology/commands/process_owl.py#L3.

cyplas commented 1 year ago

And I also wonder about config.yml. I removed clearly cypress stuff, but I suspect that more could be removed (e.g., node), though I'm not sure how to test.

danmash commented 1 year ago

@cyplas Awesome work on this! It was a long way and you did it, congratulations 🎉 Also, I would like to thank @brianpeiris who worked on this milestone. Thank you, guys 👍