Closed cyplas closed 1 year ago
Patch and project coverage have no change.
Comparison is base (
1e5462b
) 74.30% compared to head (5a450ea
) 74.30%.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@danmash Not surprisingly this PR is not passing the circleci cypress check. I'm guessing that the webhook just needs to be deleted (https://github.com/ClimateMind/climatemind-backend/settings/hooks), but I haven't used these before and don't want to make a mess. :)
Also, I upgraded black
(due to the otherwise failing lint test) and its dependencies click
and packaging
, but I see that click
is also explicitly used in ontology processing: https://github.com/ClimateMind/climatemind-backend/blob/develop/app/ontology/commands/process_owl.py#L3.
And I also wonder about config.yml. I removed clearly cypress stuff, but I suspect that more could be removed (e.g., node), though I'm not sure how to test.
@cyplas Awesome work on this! It was a long way and you did it, congratulations 🎉 Also, I would like to thank @brianpeiris who worked on this milestone. Thank you, guys 👍
Detailed information:
Replaced the cypress email e2e tests with pytest integration tests, as for the other e2e tests, and got rid of remaining cypress stuff in general.
Closing issues:
List all issues the pull request solve:
Test plan (required)