ClimateMind / climatemind-backend

Your climate action is here 🌎 Our API is a source for learning how climate change personally affects you and the things you care about most. Additionally, it will teach a scientifically proven method for communicating to others that climate change is a personally relevant issue to inspire action.
https://contribute.climatemind.org/v/rest-api/
MIT License
18 stars 19 forks source link

#444 Drop flask-selfdoc #493

Closed HutsonJason closed 1 year ago

HutsonJason commented 1 year ago

Detailed information:

Removed unused flask-selfdoc from code. Also found that the PyCharm .idea lines in the gitignore had whitespace, preventing it from ignoring the directory.

Closing issues:

List all issues the pull request solve:

Test plan (required)

danmash commented 1 year ago

Hi @HutsonJason, Thank you! I really appreciate this πŸ‘ I see that CI checks are passed in your own repo but not here. I'll investigate why and get back to you.

danmash commented 1 year ago

Hi @HutsonJason see the answer from CircleCI team

The behaviour you've observed stems from the fact that the PR author (GitHub user HutsonJason) is following the CircleCI project associated with their own fork of the climatemind-backend repository.

You need to get this user to unfollow their HutsonJason/climatemind-backend CircleCI project to allow forked PRs to trigger builds in the parent project ClimateMind/climatemind-backend.

Please refer to this Support article for more information on troubleshooting PR not triggering builds.

Could you please try this?

HutsonJason commented 1 year ago

Ok, I'm no longer following my CircleCI project. Will the PR need to be closed and reopened to trigger it?

danmash commented 1 year ago

@HutsonJason yes, let's try to open the new PR to trigger checks. Thanks

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.42 :warning:

Comparison is base (d358644) 74.30% compared to head (041e3a2) 73.88%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #493 +/- ## =========================================== - Coverage 74.30% 73.88% -0.42% =========================================== Files 85 83 -2 Lines 2681 2635 -46 Branches 315 315 =========================================== - Hits 1992 1947 -45 + Misses 657 656 -1 Partials 32 32 ``` | [Impacted Files](https://codecov.io/gh/ClimateMind/climatemind-backend/pull/493?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ClimateMind) | Coverage Ξ” | | |---|---|---| | [app/alignment/routes.py](https://codecov.io/gh/ClimateMind/climatemind-backend/pull/493?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ClimateMind#diff-YXBwL2FsaWdubWVudC9yb3V0ZXMucHk=) | `45.13% <ΓΈ> (-4.05%)` | :arrow_down: | | [app/extensions.py](https://codecov.io/gh/ClimateMind/climatemind-backend/pull/493?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ClimateMind#diff-YXBwL2V4dGVuc2lvbnMucHk=) | `100.00% <ΓΈ> (ΓΈ)` | | | [app/myths/routes.py](https://codecov.io/gh/ClimateMind/climatemind-backend/pull/493?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ClimateMind#diff-YXBwL215dGhzL3JvdXRlcy5weQ==) | `72.72% <ΓΈ> (-2.28%)` | :arrow_down: | | [app/personal\_values/routes.py](https://codecov.io/gh/ClimateMind/climatemind-backend/pull/493?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ClimateMind#diff-YXBwL3BlcnNvbmFsX3ZhbHVlcy9yb3V0ZXMucHk=) | `100.00% <ΓΈ> (ΓΈ)` | | | [app/post\_code/routes.py](https://codecov.io/gh/ClimateMind/climatemind-backend/pull/493?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ClimateMind#diff-YXBwL3Bvc3RfY29kZS9yb3V0ZXMucHk=) | `80.95% <ΓΈ> (-1.66%)` | :arrow_down: | | [app/questions/routes.py](https://codecov.io/gh/ClimateMind/climatemind-backend/pull/493?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ClimateMind#diff-YXBwL3F1ZXN0aW9ucy9yb3V0ZXMucHk=) | `100.00% <ΓΈ> (ΓΈ)` | | | [app/scoring/routes.py](https://codecov.io/gh/ClimateMind/climatemind-backend/pull/493?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ClimateMind#diff-YXBwL3Njb3Jpbmcvcm91dGVzLnB5) | `85.00% <ΓΈ> (-0.72%)` | :arrow_down: | | [app/session/routes.py](https://codecov.io/gh/ClimateMind/climatemind-backend/pull/493?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ClimateMind#diff-YXBwL3Nlc3Npb24vcm91dGVzLnB5) | `100.00% <ΓΈ> (ΓΈ)` | | | [app/solutions/routes.py](https://codecov.io/gh/ClimateMind/climatemind-backend/pull/493?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ClimateMind#diff-YXBwL3NvbHV0aW9ucy9yb3V0ZXMucHk=) | `66.66% <ΓΈ> (-2.09%)` | :arrow_down: | | [app/subscribe/routes.py](https://codecov.io/gh/ClimateMind/climatemind-backend/pull/493?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ClimateMind#diff-YXBwL3N1YnNjcmliZS9yb3V0ZXMucHk=) | `45.45% <ΓΈ> (-4.55%)` | :arrow_down: | | ... and [4 more](https://codecov.io/gh/ClimateMind/climatemind-backend/pull/493?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ClimateMind) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ClimateMind). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ClimateMind)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

HutsonJason commented 1 year ago

Ok @danmash done!