search

ClimateMind / climatemind-backend

Your climate action is here 🌎 Our API is a source for learning how climate change personally affects you and the things you care about most. Additionally, it will teach a scientifically proven method for communicating to others that climate change is a personally relevant issue to inspire action.
https://contribute.climatemind.org/v/rest-api/
MIT License
18 stars 19 forks source link

Skip Recaptcha Validation for Native Apps #497

Closed Svenstar74 closed 1 year ago

Svenstar74 commented 1 year ago

The Recaptcha is a good method for the website to counter scripting / bots. However, for our native apps on Android and iOS we don't like to have the Recaptcha. An optional skip_recaptcha parameter in the body allows to bypass the validation. Of course this is not an optimal solution, but for my estimation it is sufficiently for a small user base like we have it currently. As all the source code is open sourced, security plays an important role and we will improve it consistently.

codecov-commenter commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (ef37a1d) 73.51% compared to head (fd79324) 73.51%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #497 +/- ## ======================================== Coverage 73.51% 73.51% ======================================== Files 82 82 Lines 2598 2598 Branches 314 314 ======================================== Hits 1910 1910 Misses 656 656 Partials 32 32 ``` | [Files Changed](https://app.codecov.io/gh/ClimateMind/climatemind-backend/pull/497?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ClimateMind) | Coverage Δ | | |---|---|---| | [app/auth/routes.py](https://app.codecov.io/gh/ClimateMind/climatemind-backend/pull/497?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ClimateMind#diff-YXBwL2F1dGgvcm91dGVzLnB5) | `76.41% <0.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rodriguesk commented 1 year ago

The plan is now to have no recaptcha, and to later have recaptcha get triggered after a certain number of failed login attempts.