ClimateMind / climatemind-backend

Your climate action is here 🌎 Our API is a source for learning how climate change personally affects you and the things you care about most. Additionally, it will teach a scientifically proven method for communicating to others that climate change is a personally relevant issue to inspire action.
https://contribute.climatemind.org/v/rest-api/
MIT License
18 stars 19 forks source link

Error in chart displaying resoults of a quiz #508

Open tomaszpochron opened 7 months ago

tomaszpochron commented 7 months ago

Dear ClimateMind Development Team,

I am writing to report an issue encountered in the ClimateMind app, specifically related to the "Personal Values" chart that appears after completing a quiz. The issue arises when at least two of the personal values calculated from the quiz results are zero. Zrzut ekranu 2024-01-10 205836 Zrzut ekranu 2024-01-08 105330 The tooltip on the chart is stacked with multiple entries, all showing "Your Values: 0" for what seems to be the same personal value. The expected behavior would show a single entry per value, not multiple overlapping entries. I think it should be resolved by changing normalisation of the resoults of a quiz by changing lower bound to 1. https://github.com/ClimateMind/climatemind-backend/blob/develop/app/personal_values/normalize.py Zrzut ekranu 2024-01-11 160550

Best regards, Tomasz Pochron

danmash commented 7 months ago

Hi @tomaszpochron, Thanks for the report! Looks like you've spotted the issue already, If you feel confident about the reason you could propose a fix in a PR. I would really appreciate it. Thanks! FYI @rodriguesk