Closed VeckoTheGecko closed 11 months ago
to generate the CSV for testing purposes, run (in your activated Python environment):
python scripts/resource_converter.py -i data/resources.yml -o static/ClimateTown-Knowledge-Hub-resources.csv
👀
prettier.................................................................Failed
- hook id: prettier
- exit code: 1
[error] Cannot find package 'prettier-plugin-svelte' imported from /code/noop.js
👀
prettier.................................................................Failed - hook id: prettier - exit code: 1 [error] Cannot find package 'prettier-plugin-svelte' imported from /code/noop.js
Yeah, that's #349 😅
Describe your changes
Looks like the issue is in the
download
\ attribute (defined inButtonLinks.svelte
, called inResourceNav.svelte
)Usecases:
<a href="path-to-your-file.ext" download>Download File</a>
<a href="path-to-your-file.ext" download="custom-filename.ext">Download File</a>
download
looks like it should be a string attribute, with an empty string corresponding to usecase 1 (as per the example in this PR https://github.com/sveltejs/svelte/pull/2804/files), while a custom string can override the file name (case 2).Updating the data type and passed argument.
Related issue number/link
Fixes #345