search

ClimberMel / SMF_Add-in

Stock Market Functions for Excel using VBA
https://climbermel.github.io/SMF_Add-in/
14 stars 5 forks source link

Smf-elements-nn.txt files are formatted as Unix files (EOL LF) not Windows (EOL CRLF). #74

Open Bruce-95 opened 3 weeks ago

Bruce-95 commented 3 weeks ago

smf-Elements-nn.txt files listed here and in the latest Add-in zip file are formatted with LF (line-feed) as the end-of-line character. This is causing the elements to be read into arrays incorrectly. VBA requires CRLF when using VBA's Line Input# statement. Users are reporting multiple errors when using RCHGetElementNumber(). Problem first reported on May 15, 2024 here.

Bruce-95 commented 3 weeks ago

Opening issue for tracking.

Need to dermine which option(s) to use in the .gitattributes file as suggested here.

DecimalTurn commented 2 weeks ago

Are the files available from the website showing the raw files from GitHub like it is available from this URL (for example) or is there some kind of git checkout process that occurs?

ClimberMel commented 2 weeks ago

There should be a process created on github to update the files for the website.  Another thing for the to do list...Sent from my Galaxy -------- Original message --------From: Martin Leduc @.> Date: 2024-07-08 2:42 p.m. (GMT-08:00) To: ClimberMel/SMF_Add-in @.> Cc: Subscribed @.***> Subject: Re: [ClimberMel/SMF_Add-in] Smf-elements-nn.txt files are formatted as Unix files (EOL LF) not Windows (EOL CRLF). (Issue #74) Are the files available from the website showing the raw files from GitHub like it is available from this URL (for examaple) or is there some kind of git checkout process that occurs?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

DecimalTurn commented 2 weeks ago

Ah, so this is a manual process. Then, I'm assuming it's tempting to just download the raw file from the GitHub repo to update the website, but the way this repo is currently set up means that the LF version is the one stored as the "raw file" for GitHub.

image

This is due to the fact that * text=auto will cause all files detected as text to be converted to LF when committed to the index and GitHub uses the file in the index as the "raw file".

Unfortunately, the modification in https://github.com/ClimberMel/SMF_Add-in/pull/85 won't affect the raw file since the proposed changes only influence the checkout process. However, merging the PR would indeed fix the "download ZIP" version since GitHub does perform the equivalent of a git checkout when creating that .zip file.

image

ClimberMel commented 2 weeks ago

Yes, too much of it is a manual process.  I kept meaning to get more into the processing, but when it was just me there didn't seem like a lot of advantage to process.Sent from my Galaxy -------- Original message --------From: Martin Leduc @.> Date: 2024-07-08 7:31 p.m. (GMT-08:00) To: ClimberMel/SMF_Add-in @.> Cc: ClimberMel @.>, Comment @.> Subject: Re: [ClimberMel/SMF_Add-in] Smf-elements-nn.txt files are formatted as Unix files (EOL LF) not Windows (EOL CRLF). (Issue #74) Ah, so this is a manual process. Then, I'm assuming it's tempting to just download the raw file from the GitHub repo to update the website, but the way this repo is currently set up means that the LF version is the one stored as the "raw file" for GitHub. image.png (view on web) This is due to the fact that * text=auto will cause all files detected as text to be converted to LF when committed to the index and GitHub uses the file in the index as the "raw file". Unfortunately, the modification in #85 won't affect the raw file since the proposed changes only influence the checkout process. However, merging the PR would indeed fix the "download ZIP" version since GitHub does perform the equivalent of a git checkout when creating that .zip file. image.png (view on web)

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>