search

ClimbsRocks / machineJS

[UNMAINTAINED] Automated machine learning- just give it a data file! Check out the production-ready version of this project at ClimbsRocks/auto_ml
https://github.com/ClimbsRocks/auto_ml
408 stars 64 forks source link

Open Validation Indices file for pickling as binary #177

Closed TalhaAsmal closed 8 years ago

TalhaAsmal commented 8 years ago

Strictly speaking, all pickle files should be opened as binary (reading or writing). This is just to follow that convention, and prepare for Python3 compatibility

ClimbsRocks commented 8 years ago

Long delay in getting to this, but thanks for the PR!

I recently found out about protocol=2, which limits some amount of backwards compatibility to much earlier versions of Python, but makes reading and writing pickled files much faster. Thought you might find it useful :)

Thanks for the PR!