VCI Expert Review and Approval - Provisional Interpretation

[jimmyzhen]

Implement the Provisional Interpretation section, which consists of the following requirements:

1. Section panel title: Provisional Interpretation
2. A dropdown of by Individual or on behalf of Group options for the user to select.
3. Dropdown label: Interpretation being saved 'by Individual' or 'on behalf of Group'
4. Display of form fields for labels ClinGen Group Name OR Non-ClinGen Group Name. Either one of these fields is required if the on behalf of Group option is selected.
5. A Save as Provisional Interpretation button for the user to save the selected option from the dropdown.
6. The dropdown selection is required if the user wants to save the provisional interpretation.
7. Display of a note with message: Note: Saving as a Provisional Interpretation does not submit it to ClinVar.
8. Display of the Current Saved Provisional Interpretation, including the timestamp.

[jimmyzhen]

@selinad, @wrightmw,

I've addressed the timestamp and word wrapping issues, and have updated the instance. Please review again: https://jz-approval-workflow.demo.clinicalgenome.org

[selinad]

@jimmyzhen thank you!

Timestamp appears to update on last edit of an evalution (not summary), but this is good if not the best.

I still see wrapping -- not critical, IMHO, for this release -- a long title will be unusual, but I'm not certain the time involved to address

[selinad]

@jimmyzhen I take it back - it's also wrapping with the shorter titles:

[jimmyzhen]

@selinad,

I suspect this is due to the missing CSS in the test instance. It is looking okay in my local instance:

[selinad]

@jimmyzhen looks fantastic! Thanks for checking it on your local instance. The release candidate will have the missing CSS, correct?

[jimmyzhen]

@selinad,

Yes, it will.

[wrightmw]

Very minor point... in the Provisional/Approval process the field for Affiliations is named "ClinGen Affiliation" but we may wish to change this in future to just "Affiliation"... we already have some Affiliations that are not "ClinGen" and in time there will no doubt be many more.

[jimmyzhen]

@wrightmw Please create a ticket for this so that we can address it in one of the subsequent releases. Thank you.

[selinad]

@jimmyzhen unfortunatley @wrightmw and I both get this message

when clicking on "View Provisional Summary" after saving a Provisional in the VCI

[selinad]

@jimmyzhen one thing I now can't remember whether I noticed or is newly introduced.

When you have this screen (just saved a summary and there IS an associated disease)

If you hit Edit, you get this:

The good news is the ability to save as Provisional disappears, but the need a disease note appears even though one already exists. It's' not a big deal as when I hit Save again, it gives me provisional option....I think we can fix it for next time unless it is "quick" to remove this button.

[selinad]

@jimmyzhen this is my bad for not catching earlier -- the display here is a bit confusing:

Would it be quick to make the Provisional/Approved Status and tag be on the same line as the rest of the info for the interpretation? Or, the "Provisional/Approved Status:" title could be removed and the "Approve" button could go tight after the datestamp on the same line.

If neither of these quick, I'll make a ticket for next time -- I don't think there will be too many variants with multiple interpreters.

[selinad]

• [x] @jimmyzhen can you please change the BCM-Education approver to be Deb Ritter rather than the Affiliation itself? thank you!

[selinad]

@jimmyzhen everything looks great except for the 2 items (and it sounds like one is only because the new VCI Summary page didn't get added to the rc). The other item (disease needed message showing when click Edit on summary) is not critical, but if quick to fix would be less confusing....It seems like anytime the edit is hit, no warning should appear as it should only happen on Save as needed.

Putting in needs work and you can decide. thx @jimmyzhen -- this was a HUGE project done very nicely! THANK YOU!!!

[jimmyzhen]

@selinad @wrightmw,

I have fixed the view provisional/approval summary problem in the VCI. Please try again and let me know there are any problems. Thanks.

[selinad]

@jimmyzhen it works!! Thank you !

• [x] I'm not sure I'd seen it for a variant with a CV and CA ID -- a space needed between the IDs if simple:

[jimmyzhen]

@selinad,

If we are gonna make the VCI status(es) inline with the timestamp, they may wrap to the next line (e.g. the APPROVED is in one line and the NEW PROVISIONAL is in the next) when you have something like the screenshot below:

Would you still prefer to make status(es) inline with timestamp?

[selinad]

thx @jimmyzhen -- would it be quick to slightly increase the space between interpretations for now?

[jimmyzhen]

@selinad It will be slightly quicker.

[selinad]

Implemented in R18 -- great work @jimmyzhen !!!!