Change names of Affiliations to match new agreed format

[wrightmw]

All Affiliation names in the interfaces will need to be changed before the next release to match a new agreed name format. This will mirror the website display, short version. Name format: [Group Name] EP
Examples: Hearing Loss EP, Autism and Intellectual Disability EP​

Dependency: The full list of new names will be provided by the Geisinger team.

[wrightmw]

@ErinRiggs We need to have the agreed new names for the current Affiliations by the end of business on Monday so that they can be included in the next release. It's fairly important that these are sorted when the publication feature goes live in the next release because summaries on the website will include the names from the GCI. Should we have to change the names of these Affiliations at a later date then some summaries will have the old names and some the new, unless they are then re-published to the website. So, it would definitely be preferable to get the new names into this release.

Please see below a table of the old/current names in the GCI/VCI and new names I have transposed based on your formula that was agreed in the GCI WG call. Would it be ok to go ahead with these new names if we don't hear otherwise? Please advise any changes you think we should make. Thanks.

[jimmyzhen]

Addressing this ticket in the #1695 branch.

[jimmyzhen]

Hi @selinad, @wrightmw,

Please review the following instance for the fixes/changes requested in this ticket: https://1695-jz-exac-fix.demo.clinicalgenome.org

[selinad]

@jimmyzhen looking good overall, with what I think are a few needed updates:

• need "Cardiovascular" in front of "Familial Hyper...."
• it looks like it should be "Aminoacidopathy" rather than "Aminoacidopathies"
• looks like it should just be "Hereditary Cancer EP"
• looks like it should be "ClinGen Biocuration Core" (not "ClinGen Gene Curation Core")

@wrightmw please let me know if above edits are correct. thx!

[wrightmw]

@jimmyzhen Yes, I agree with those edits suggested by @selinad

[wrightmw]

@jimmyzhen In addition to the above edits, there is one further edit, which I have wrong in the table above. "Intellectual Disability & Autism EP" should be:

• Autism and Intellectual Disability EP

[jimmyzhen]

@selinad, @wrightmw,

Great catch on my mistakes! Thank you both!

I have corrected them and updated the instance. Please give it another look when you get a chance.

[selinad]

@jimmyzhen all looks good now! @wrightmw I've pasted in the corrected table for reference (please check). Thank you!

[wrightmw]

@selinad All looks good to me!

[selinad]

This all looks correct, @jimmyzhen ! Also includes Mitochondrial Diseases EP now:

[wrightmw]

Thanks to @selinad manually typing in this list of AffiliationIDs into her name, I was able to copy across these into my name super-quick. All new names are present and correct @jimmyzhen