search

ClinGen / clincoded

This GCI/VCI 1.0 platform has now been retired, and replaced with our new 2.0 platform:
https://github.com/ClinGen/gene-and-variant-curation-tools/issues
MIT License
25 stars 9 forks source link

Change name of Affiliation #1801

Closed wrightmw closed 5 years ago

wrightmw commented 5 years ago

Change name of “ClinGen Biocuration Core” to "General Gene Curation EP".

wrightmw commented 5 years ago

I think we agreed to making this name change? We can do this upon the next release. @ErinRiggs @marinadistefano @jennygoldstein @courtneythaxton

ErinRiggs commented 5 years ago

?Yes! Please go ahead :)

Erin Rooney Riggs, MS, CGC

Assistant Professor

Certified Genetic Counselor

Autism & Developmental Medicine Institute

Geisinger

eriggs@geisinger.edumailto:eriggs@geisinger.edu

From: Matt W. Wright notifications@github.com Sent: Wednesday, October 10, 2018 5:16 PM To: ClinGen/clincoded Cc: Riggs, Erin; Mention Subject: [External] Re: [ClinGen/clincoded] Change name of Affiliation (#1801)

I think we agreed to making this name change? We can do this upon the next release. @ErinRiggshttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FErinRiggs&data=02%7C01%7Ceriggs%40geisinger.edu%7C8ec837400d8a4c7f174008d62efe07d2%7C37d46c567c664402a16055c2313b910d%7C0%7C0%7C636748065917016240&sdata=imJdUFTuLJyFUuBtABS6%2F%2BGGwPJjSNbVYI285r%2BtND0%3D&reserved=0 @marinadistefanohttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmarinadistefano&data=02%7C01%7Ceriggs%40geisinger.edu%7C8ec837400d8a4c7f174008d62efe07d2%7C37d46c567c664402a16055c2313b910d%7C0%7C0%7C636748065917016240&sdata=UE0Itlj9wpK3Y%2FXIujKxyLu3%2FAYRsxVi%2FTQPT1LDcwk%3D&reserved=0 @jennygoldsteinhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjennygoldstein&data=02%7C01%7Ceriggs%40geisinger.edu%7C8ec837400d8a4c7f174008d62efe07d2%7C37d46c567c664402a16055c2313b910d%7C0%7C0%7C636748065917026249&sdata=b9McGKlytS26Ntgd96S7lKu4fXLmaypVxPpqdiika4k%3D&reserved=0 @courtneythaxtonhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fcourtneythaxton&data=02%7C01%7Ceriggs%40geisinger.edu%7C8ec837400d8a4c7f174008d62efe07d2%7C37d46c567c664402a16055c2313b910d%7C0%7C0%7C636748065917036257&sdata=59ja7w8Gl54AV6Nv6ixwL18%2FGTsHNSxFKZ0SZ%2FERu1M%3D&reserved=0

- You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FClinGen%2Fclincoded%2Fissues%2F1801%23issuecomment-428752348&data=02%7C01%7Ceriggs%40geisinger.edu%7C8ec837400d8a4c7f174008d62efe07d2%7C37d46c567c664402a16055c2313b910d%7C0%7C0%7C636748065917036257&sdata=EyN7UJFRs%2FxcvQ%2Bn2tiZcuBpi01Sm2Aq7wQ%2BXMtPxTM%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAcqZlBBfMYSqPJzrXQbIvfu7aBH4o1urks5ujnG-gaJpZM4XWbkf&data=02%7C01%7Ceriggs%40geisinger.edu%7C8ec837400d8a4c7f174008d62efe07d2%7C37d46c567c664402a16055c2313b910d%7C0%7C0%7C636748065917046266&sdata=nhzGQSNC9IRPpJufJY1vzWninsDagsbBd5kCo%2BPK%2F3U%3D&reserved=0.

IMPORTANT WARNING: The information in this message (and the documents attached to it, if any) is confidential and may be legally privileged. It is intended solely for the addressee. Access to this message by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken, or omitted to be taken, in reliance on it is prohibited and may be unlawful. If you have received this message in error, please delete all electronic copies of this message (and the documents attached to it, if any), destroy any hard copies you may have created and notify me immediately by replying to this email. Thank you. Geisinger Health System utilizes an encryption process to safeguard Protected Health Information and other confidential data contained in external e-mail messages. If email is encrypted, the recipient will receive an e-mail instructing them to sign on to the Geisinger Health System Secure E-mail Message Center to retrieve the encrypted e-mail.

jimmyzhen commented 5 years ago

@wrightmw,

By changing ClinGen Biocuration Core to General Gene Curation EP for affiliation ID 10026, we will be removing the recently added 10030 affiliation, correct?

wrightmw commented 5 years ago

@jimmyzhen Yes, that's correct. You can nuke 10030.

larrybabb commented 5 years ago

@wrightmw - somewhat related - but different. This may need verification... I was looking at the affiliation json file and noticed that then abbreviation seemed odd for the Hypertrophic Cardio group

  "affiliation_id": "10008",
        "affiliation_abbreviation": "HLWG",
        "affiliation_fullname": "Hypertrophic Cardiomyopathy EP",
        ...

It seems to me that HLWG would resonate more with the Hearing Loss WG which happens to be the affiliation before (in the file) .

  "affiliation_id": "10007",
        "affiliation_abbreviation": "",
        "affiliation_fullname": "Hearing Loss EP",

I could be wrong, but it seemed odd enough that I felt I should bring it to your attention to have verified.

wrightmw commented 5 years ago

@larrybabb You're right, it looks like that abbreviation is incorrect for this affiliation. We can fix that (@jimmyzhen) by removing it altogether from this entry. The "affiliation_abbreviation" is pretty much vestigial now, it was decided on GCI WG calls that we would only use the one full name and nothing else... so we won't be populating this field moving forward.

wrightmw commented 5 years ago

Name has been changed. Thanks @jimmyzhen

jimmyzhen commented 5 years ago

Included in R23 release.