ClinGen / clincoded

This GCI/VCI 1.0 platform has now been retired, and replaced with our new 2.0 platform:
https://github.com/ClinGen/gene-and-variant-curation-tools/issues
MIT License
25 stars 9 forks source link

Animal Model Only tag #1959

Closed wrightmw closed 4 years ago

wrightmw commented 5 years ago
Screen Shot 2019-06-27 at 9 46 04 AM

Screenshot from presentation by @marinadistefano just now.

@marinadistefano @ErinRiggs @jennygoldstein @courtneythaxton Would you like us to automatically add a tag in the Evidence Summary or somewhere else in the GCI?

courtneythaxton commented 5 years ago

I like the idea of having a tag for this on the Evidence summary or have it highlighted somewhere

Courtney Thaxton, Ph.D. Assistant Director, UNC Biocuration and Coordination Core Berg Lab, UNC Dept. of Genetics 120 Mason Farm Road 5100 B, Genetic Medicine Building CB#7264 University of North Carolina, Chapel Hill, NC 27599 919-966-9562

From: "Matt W. Wright" notifications@github.com<mailto:notifications@github.com> Reply-To: ClinGen/clincoded reply@reply.github.com<mailto:reply@reply.github.com> Date: Thursday, June 27, 2019 at 12:54 PM To: ClinGen/clincoded clincoded@noreply.github.com<mailto:clincoded@noreply.github.com> Cc: Courtney Thaxton courtney_thaxton@med.unc.edu<mailto:courtney_thaxton@med.unc.edu>, Mention mention@noreply.github.com<mailto:mention@noreply.github.com> Subject: [ClinGen/clincoded] Animal Model Only tag (#1959)

[Screen Shot 2019-06-27 at 9 46 04 AM]https://user-images.githubusercontent.com/15131169/60284483-8724f600-98c0-11e9-9164-65582bc501db.png

Screenshot from presentation by @marinadistefanohttps://github.com/marinadistefano just now.

@marinadistefanohttps://github.com/marinadistefano @ErinRiggshttps://github.com/ErinRiggs @jennygoldsteinhttps://github.com/jennygoldstein @courtneythaxtonhttps://github.com/courtneythaxton Would you like us to automatically add a tag in the Evidence Summary or somewhere else in the GCI?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/ClinGen/clincoded/issues/1959?email_source=notifications&email_token=AHYF4VMOFOMC2BQP5L7TAEDP4TWDRA5CNFSM4H356762YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G4ECM3A, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AHYF4VOVPX5PD7SLCP3XJHTP4TWDRANCNFSM4H35676Q.

wrightmw commented 5 years ago

Maybe right at the top of the Evidence Summary in the top box? @marinadistefano @ErinRiggs @jennygoldstein @courtneythaxton

Screen Shot 2019-06-27 at 10 01 52 AM

wrightmw commented 5 years ago

And somewhere at the bottom of the Classification Matrix? Screen Shot 2019-06-27 at 10 04 48 AM

marinadistefano commented 5 years ago

Matt,

You're slated to join the GC small call on Monday. We could confirm then.

Marina


From: Matt W. Wright notifications@github.com Sent: Thursday, June 27, 2019 1:05:34 PM To: ClinGen/clincoded Cc: DiStefano, Marina,Ph.D.; Mention Subject: Re: [ClinGen/clincoded] Animal Model Only tag (#1959)

    External Email - Use Caution

And somewhere at the bottom of the Classification Matrix? [Screen Shot 2019-06-27 at 10 04 48 AM]https://user-images.githubusercontent.com/15131169/60285763-17fcd100-98c3-11e9-8122-e32523642e1b.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/ClinGen/clincoded/issues/1959?email_source=notifications&email_token=AHFKA6SEPZVOCBSZX3TMHRLP4TXN5A5CNFSM4H356762YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYXYMAI#issuecomment-506430977, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AHFKA6WJZQZVA5FCPGGPY5DP4TXN5ANCNFSM4H35676Q.

The information in this e-mail is intended only for the person to whom it is addressed. If you believe this e-mail was sent to you in error and the e-mail contains patient information, please contact the Partners Compliance HelpLine at http://www.partners.org/complianceline . If the e-mail was sent to you in error but does not contain patient information, please contact the sender and properly dispose of the e-mail.

wrightmw commented 5 years ago

@marinadistefano Sounds good to me!

wrightmw commented 5 years ago

@marinadistefano @ErinRiggs @jennygoldstein @courtneythaxton I can't make this Monday's meeting. I can join the following week, or you guys could discuss this without me and fill in the details in this ticket?

marinadistefano commented 5 years ago

We can probably just fill in the ticket without you Matt. Thanks!

On Jun 28, 2019, at 12:00 AM, Matt W. Wright notifications@github.com<mailto:notifications@github.com> wrote:

    External Email - Use Caution

@marinadistefanohttps://github.com/marinadistefano @ErinRiggshttps://github.com/ErinRiggs @jennygoldsteinhttps://github.com/jennygoldstein @courtneythaxtonhttps://github.com/courtneythaxton I can't make this Monday's meeting. I can join the following week, or you guys could discuss this without me and fill in the details in this ticket?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/ClinGen/clincoded/issues/1959?email_source=notifications&email_token=AHFKA6VG67VM4SWDIHLLHSTP4WEFXA5CNFSM4H356762YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYY7PTA#issuecomment-506591180, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AHFKA6UM5CWYGIG7HCUY4T3P4WEFXANCNFSM4H35676Q.

The information in this e-mail is intended only for the person to whom it is addressed. If you believe this e-mail was sent to you in error and the e-mail contains patient information, please contact the Partners Compliance HelpLine at http://www.partners.org/complianceline . If the e-mail was sent to you in error but does not contain patient information, please contact the sender and properly dispose of the e-mail.

gcheung-SF commented 5 years ago

How about adding the tag in following area? -- Evidence Summary

Screen Shot 2019-06-28 at 4 31 56 PM

-- Classification Matrix

Screen Shot 2019-06-28 at 4 34 45 PM
ErinRiggs commented 5 years ago

Hi Gloria! Thanks for getting this started. A few suggestions:

wrightmw commented 5 years ago

@sgoehringer and @tnavatar ... can you let us know the logic you are using to apply the "animal model only" tag on the website to make sure we are applying this tag in the same way?

gcheung-SF commented 5 years ago

The Animal Model tag should only apply if the final classification is automatically calculated as "No Known Disease Relationship" (previous know as "No Reported Evidence", changed in #1913) and there is only non-human data.

The tags to appear 1) Next to "modified classification" at the top (blue box under the words "Evidence Summary" and 2) Next to calculated classification at the bottom on the classification matrix

wrightmw commented 4 years ago

Looks great. Exactly as expected. Tag appears (in Classification Matrix and Evidence Summary) with No Reported Evidence only when there is non-human only evidence.

wrightmw commented 4 years ago

Released in R32