search

ClinGen / clincoded

This GCI/VCI 1.0 platform has now been retired, and replaced with our new 2.0 platform:
https://github.com/ClinGen/gene-and-variant-curation-tools/issues
MIT License
25 stars 9 forks source link

Curator form page styling #37

Closed forresttanaka closed 8 years ago

forresttanaka commented 9 years ago

Create demo page with curator input forms using React components for form elements.

forresttanaka commented 9 years ago

On the Curation Central page, I have the Add PMID modal dialog box appearing. It doesn’t do anything yet however. I have a new generic modal dialog React component, and you pass it another React component as its content.

add-pmid-modal

forresttanaka commented 9 years ago

I have the beginnings of the Create Gene Disease page. It’s in the curation_page.json test data so it’s working with the curation_page schema. The input elements are React components. In ENCODED we use the react-bootstrap library, but I’ve not been very happy with its slow progress and having to go through so many hoops to get it to do what we want, when I can just write what we need more quickly.

create-gene-disease

kgliu0101 commented 9 years ago

looks great

On Wed, Jun 24, 2015 at 6:06 PM, Forrest Tanaka notifications@github.com wrote:

I have the beginnings of the Create Gene Disease page. It’s in the curation_page.json test data so it’s working with the curation_page schema. The input elements are React components. In ENCODED we use the react-bootstrap library, but I’ve not been very happy with its slow progress and having to go through so many hoops to get it to do what we want, when I can just write what we need more quickly.

[image: create-gene-disease] https://cloud.githubusercontent.com/assets/1181324/8344843/83a514da-1a9b-11e5-889a-b2a80df636a4.png

— Reply to this email directly or view it on GitHub https://github.com/ClinGen/clincoded/issues/37#issuecomment-115059531.

kgliu0101 commented 9 years ago

I'm working on modeling gdm, evidence and article. Hope able to provide some data to you tomorrow

On Wed, Jun 24, 2015 at 10:15 PM, Kang Liu kgliu0101@gmail.com wrote:

looks great

On Wed, Jun 24, 2015 at 6:06 PM, Forrest Tanaka notifications@github.com wrote:

I have the beginnings of the Create Gene Disease page. It’s in the curation_page.json test data so it’s working with the curation_page schema. The input elements are React components. In ENCODED we use the react-bootstrap library, but I’ve not been very happy with its slow progress and having to go through so many hoops to get it to do what we want, when I can just write what we need more quickly.

[image: create-gene-disease] https://cloud.githubusercontent.com/assets/1181324/8344843/83a514da-1a9b-11e5-889a-b2a80df636a4.png

— Reply to this email directly or view it on GitHub https://github.com/ClinGen/clincoded/issues/37#issuecomment-115059531.

forresttanaka commented 9 years ago

The Create Gene Disease page now checks the input Orphanet ID (not quite the right format yet) against Kang’s disease data, and gives an error message if the ID doesn’t exist, and goes to the next page if it does.

check-orphanet

forresttanaka commented 9 years ago

Group curation page panels done. Still needs some styling, but you can look at the mechanism. The design with the tabs on the left from the PPT are hard to scale to mobile.

group-curation

kilodalton commented 8 years ago

Great job. Thanks for all your hard work to get the app to production!