ClinGen / clincoded

This GCI/VCI 1.0 platform has now been retired, and replaced with our new 2.0 platform:
https://github.com/ClinGen/gene-and-variant-curation-tools/issues
MIT License
25 stars 9 forks source link

Fix BA1 hover text #916

Closed kilodalton closed 8 years ago

kilodalton commented 8 years ago

Currently BA1 hover text is the same as BS1.

@wrightmw says it should be: "Allele frequency greater than 5% in a population database"

kilodalton commented 8 years ago

@wrightmw @selinad Does this look right?

BA1:

image

BS1:

image

selinad commented 8 years ago

Looks great. Thx @kilodalton.

(@wrightmw I assume you like "a database" better...)

kilodalton commented 8 years ago

For reference.

The (new) current hover text for all:

wrightmw commented 8 years ago

@selinad ...yeah, it was a last minute re-jig...I thought that 'some databases' implied it had to be in more than one databases, whereas for the rule to apply it only has be to found above 5% in one of the databases

selinad commented 8 years ago

It works. They'll let us know if it's too specific :). Thx!

wrightmw commented 8 years ago

BA1 hover text is correct now.

selinad commented 8 years ago

Looks great - thx!

kilodalton commented 8 years ago

Included in last release (R7alpha2). Nice job and thanks for your hard work.