search

ClinGen / gene-and-variant-curation-tools

ClinGen's gene and variant curation interfaces (GCI & VCI). Developed by Stanford ClinGen team.
https://curation.clinicalgenome.org/
MIT License
3 stars 1 forks source link

Text changes in GCI #325

Closed markmandell closed 11 months ago

markmandell commented 1 year ago

Here is a spreadsheet for text changes in the GCI: https://docs.google.com/spreadsheets/d/1F7utEa9da7nZmCUH1osLUn2jnAvhvQPOn66o1DNWVmA/edit#gid=0

Contains the location of text in GCI, the change, and additional notes regarding the change

liammulh commented 1 year ago

I am not sure who to @ (@wrightmw?), but I have a question:

I noticed that in the "Curate Family Information" page, the first "Family Label" input you see (1) doesn't have the text "Note: Do not enter real names in this field.", but farther down on the page, there is a label (2) that does have the text "Note: Do not enter real names in this field." Does (1) need the "Note: Do not enter real names in this field." text as well?

EDIT: I also noticed that the "Curate Group Information" page has an input that lacks the note (3). Does (3) need the "Note: Do not enter real names in this field." text?

(1) Doesn't have "Note: Do not enter real names in this field."

family-no-note

(2) Does have "Note: Do not enter real names in this field."

family-yes-note

(3) Group input without "Note: Do not enter real names in this field."

group-no-note
wrightmw commented 1 year ago

@liammulh Good spot! Please add that Note to all the field texts indicated.

liammulh commented 1 year ago

@wrightmw, do you want the changes to the classification matrix done for SOP v7 and SOP v5 as well? I ask because most (all?) of the genes in my local gci-vci-aws instance use SOP v8.

liammulh commented 1 year ago

One of the requests is to add an asterisk to the circled label to indicate it is a required field:

where-to-add-asterisk

(This label is in the Disease(s) & Phenotype(s) section of the Curate Case Control Evidence page.)

Whether the asterisk is shown next to that label is controlled programmatically. I don't feel comfortable manually changing the flag in the code that determines whether to show the asterisk because I don't know how changing that flag would affect other parts of the code. Since this issue is for text changes, I think this request is outside the scope of this issue. If we feel it's a priority to make this change, then we should open a separate issue and link to this comment in that issue.

EDIT: Issue here.

Code - The aforementioned label is part of the `GroupDisease` component, which gets imported and used in the `CaseControlCuration` component: https://github.com/ClinGen/gci-vci-aws/blob/10049d1af0b5883fa0dd723fcb50b3b17ff5f580/gci-vci-react/src/components/gene-central/curations/case-control/CaseControlCuration.js#L1065-L1066 - When you use the `GroupDisease` component, you are supposed to pass a boolean flag that indicates whether the disease is required. This flag is then used to determine whether to show the asterisk.
liammulh commented 11 months ago

Changes are in the production website.