search

Clinical-Genomics-Lund / SomaticPanelPipeline

0 stars 2 forks source link

Appending groupID with 'p' for the paired vcf #42

Closed ramsainanduri closed 8 months ago

ramsainanduri commented 8 months ago

41

alkc commented 8 months ago

I'm not going to do an in-depth review since @sailepradh is already assigned, but I've one comment:

why not append paired instead of p? The filename becomes a little bit longer, but it becomes easier to remember what the p stands for without having to look it up.

sailepradh commented 8 months ago

I agree what @alkc said but I am not sure the butterfly it would bring to the later downstreaming (for example : opening in coyote ). if it is not much then we can add paired :)

ramsainanduri commented 8 months ago

I think its good to have 'paired' but I made it 'p' just to follow the old structure what we currently rely on. May be we can think of it for the future updates.