Clinical-Genomics / BALSAMIC

Bioinformatic Analysis pipeLine for SomAtic Mutations In Cancer
https://balsamic.readthedocs.io/
MIT License
45 stars 16 forks source link

Verification Report [v14.0.1] #1410

Closed khurrammaqbool closed 8 months ago

khurrammaqbool commented 8 months ago

Balsamic Verification Report

Release Information

Person(s) involved in the development of new release

Summary

The purpose of this verification is to fix a bug appeared in PureCN rules crashing due to the purecn command failing to estimate purity and ploidy. This leads to the whole pipeline crash because of the bash strict mode in effect from snakemake. The solution, implemented in the current release, is to bypass the exit code and making the condition associated, in case of failing the command to estimate purity and ploidy, with the output generating default values of purity=0.02 and ploidy=2, with a comment "FAILED PURITY ESTIMATION" to the table.

In addition a small bug fix has been included wherein the wrong container name used in the CNVkit PON creation workflow has been corrected.

These are the goals of this verification:

  1. Evaluate the solution performs as expected, the analysis completes without crashing and a default table is generated in case purity and ploidy estimation fails.

Changelog

Type Pull Request Performed tests
Fixed https://github.com/Clinical-Genomics/BALSAMIC/pull/1406 Analysis completed generating the default table
Fixed https://github.com/Clinical-Genomics/BALSAMIC/pull/1412 CNVkit PON creation rules no longer failing with missing container

Pre-Verification Checklist

Before proceeding with the verification process, ensure that the following tasks have been completed:

Verification Results

Workflow Integrity Verification Cases

Case ID Analysis type Expected QC Status
acetuna QC, tumor-only Pass Pass
civilsole WGS, tumor-only Fail (PCT_60X=0.004532) Pass
fleetjay WGS, tumor-normal Fail (PCT_60X=0.00836) Pass
setamoeba TGA, tumor-only Pass Pass
unitedbeagle TGA, tumor-normal Pass Pass
uphippo UMI, tumor-only Fail (GC dropout=1.650392) Pass
equalbug UMI, tumor-normal Fail (GC_DROPOUT=1.087173 and RELATEDNESS=-0.524) Pass
bettertahr TGA, tumor-only (Fails to compute purity and ploity and uses default) Pass
firstlobster CNVkit PON test case (myeloid 5.3) Workflow finishes without error and produces PON Pass

Storage, Delivery and Upload Integrity Verifications

Processes Affected in current version Affected workflows
New files to be stored No NA
New files to be delivered No NA
New files to be uploaded to Scout No NA
Changes to Housekeeper IDs No NA
Changes to Scout upload No NA
Case ID Analysis type Storage status Delivery status Upload status
acetuna QC, tumor-only NA NA NA
civilsole WGS, tumor-only NA NA NA
fleetjay WGS, tumor-normal NA NA NA
setamoeba TGA, tumor-only NA NA NA
unitedbeagle TGA, tumor-normal NA NA NA
uphippo UMI, tumor-only NA NA NA
equalbug UMI, tumor-normal NA NA NA

Version Specific Verification Cases

Case ID Analysis type Expected QC Status
bettertahr TGA, tumor-only (Fails to compute purity and ploity and uses default) Pass
firstlobster CNVkit PON test case (myeloid 5.3) Workflow finishes without error and produces PON Pass

Issues Identified

No Issues on related to the verification of BALSAMIC, but some challenges running the validation cases on stage. The documentation to install and run BALSAMIC on stage is not up-to-date.

Recommendations

Conclusion

BALSAMIC patch release v14.0.1 fixes two bugs. One related to the handling of the workflow in case the computation purity and ploidy fails and second a fix for container name in the PON workflow. The verification process has been conducted successfully. The patch release has been evaluated positively, for both bug fixes, with different QoS scenarios.


Approval

Deployment

ivadym commented 8 months ago

Signed! @khurrammaqbool @mathiasbio

I've marked as NA the section you identified as irrelevant for more clarity and checked the CNV report PDF! Everything looks all right! ⭐

ivadym commented 8 months ago

I've just noticed that equalbug and uphippo have been started as balsamic analysis, not balsamic-umi. Similarly, acetuna should have been started as balsamic-qc. These workflows have not been verified.

ivadym commented 8 months ago

What's the status, @khurrammaqbool? Have we already rerun these cases? Are we deploying tomorrow? It would be good to bump the version today and copy the Balsamic cache from stage to production

mathiasbio commented 8 months ago

Have confirmed, equalbug, upphippo and acetuna has been re-run and finished yesterday with the correct workflow 👍 @ivadym

ivadym commented 8 months ago

Nice! Thanks @mathiasbio! I've updated the signature date so I think we're good to go 🛫