Closed khurrammaqbool closed 8 months ago
Signed! @khurrammaqbool @mathiasbio
I've marked as NA the section you identified as irrelevant for more clarity and checked the CNV report PDF! Everything looks all right! ⭐
I've just noticed that equalbug
and uphippo
have been started as balsamic
analysis, not balsamic-umi
. Similarly, acetuna
should have been started as balsamic-qc
. These workflows have not been verified.
What's the status, @khurrammaqbool? Have we already rerun these cases? Are we deploying tomorrow? It would be good to bump the version today and copy the Balsamic cache from stage to production
Have confirmed, equalbug, upphippo and acetuna has been re-run and finished yesterday with the correct workflow 👍 @ivadym
Nice! Thanks @mathiasbio! I've updated the signature date so I think we're good to go 🛫
Balsamic Verification Report
Release Information
v14.0.1
Patch
Person(s) involved in the development of new release
Summary
The purpose of this verification is to fix a bug appeared in PureCN rules crashing due to the purecn command failing to estimate purity and ploidy. This leads to the whole pipeline crash because of the bash strict mode in effect from snakemake. The solution, implemented in the current release, is to bypass the exit code and making the condition associated, in case of failing the command to estimate purity and ploidy, with the output generating default values of purity=0.02 and ploidy=2, with a comment "FAILED PURITY ESTIMATION" to the table.
In addition a small bug fix has been included wherein the wrong container name used in the CNVkit PON creation workflow has been corrected.
These are the goals of this verification:
Changelog
Pre-Verification Checklist
Before proceeding with the verification process, ensure that the following tasks have been completed:
[x] Install Balsamic in stage and production environments in hasta and build its cache.
BALSAMIC release_v14.0.1
branch, from the instructions given above:sudo <...>
tmux new -s <...>
pip uninstall balsamic
pip install --no-cache-dir -U git+https://github.com/Clinical-Genomics/BALSAMIC@release_v14.0.1
COSMIC_KEY=<...>
balsamic init --out-dir <STAGE_PATH> --account <...> --cosmic-key ${COSMIC_KEY} --genome-version hg19 --cache-version 14.0.1 --run-mode local --snakemake-opt "--cores 4" -r
[x] Confirm the availability of necessary resources, such as test cases.
[x] Review the changelog and ensure all changes and updates are documented:
[x] Set up the stage environment with the necessary software and configurations:
Verification Results
Workflow Integrity Verification Cases
acetuna
civilsole
PCT_60X=0.004532
)fleetjay
PCT_60X=0.00836
)setamoeba
unitedbeagle
uphippo
GC dropout=1.650392
)equalbug
GC_DROPOUT=1.087173
andRELATEDNESS=-0.524
)bettertahr
firstlobster
Storage, Delivery and Upload Integrity Verifications
acetuna
civilsole
fleetjay
setamoeba
unitedbeagle
uphippo
equalbug
Version Specific Verification Cases
bettertahr
firstlobster
Issues Identified
No Issues on related to the verification of BALSAMIC, but some challenges running the validation cases on stage. The documentation to install and run BALSAMIC on stage is not up-to-date.
Recommendations
Conclusion
BALSAMIC patch release v14.0.1 fixes two bugs. One related to the handling of the workflow in case the computation purity and ploidy fails and second a fix for container name in the PON workflow. The verification process has been conducted successfully. The patch release has been evaluated positively, for both bug fixes, with different QoS scenarios.
Approval
Deployment