Clinical-Genomics / cg

Glue between Clinical Genomics apps
8 stars 2 forks source link

Add a "validate" step before storage to microSALT and Mutant #1648

Closed Vince-janv closed 2 months ago

Vince-janv commented 1 year ago

Description

Since we have no bioinformaticians willing or able to work on QC within the microSALT and Mutant code i suggest doing it in cg.

Suggested solution

To remedy the lack of QC within the microSALT and Mutant pipelines I suggest implementing a vary rudimentary "validate" method to the two analysis-apis respectively. This will be called before or within the cg workflow store command. This should in turn set the analysis as failed in trailblazer, mimicking the behaviour in the other pipelines.

This can be closed when

Blocked by

If there are any blocking issues/prs/things in this or other repos. Please link to them.

pbiology commented 1 year ago

If/when this gets decided to be implemented, can we add in issues to remove these things and instead incorporate the QC checks into Clinical-Genomics/project-planning#410 and Clinical-Genomics/project-planning#23

Vince-janv commented 1 year ago

Decision:

pbiology commented 1 year ago

So JASEN is very closed to release. The latest status updates (22-12-01) basically says that it should happen during December 2022. Adding some module for QC also should be very possible going forward.

Once a stable version is released we should look into proper replacement of mircroSALT with JASEN, making sure that it can function as a 1:1 replacement etc. So pretty much making sure we get project Clinical-Genomics/project-planning#23 back on track