Clinical-Genomics / cg

Glue between Clinical Genomics apps
6 stars 2 forks source link

Microsalt cases are not storing #2500

Closed SofiaOtero closed 10 months ago

SofiaOtero commented 10 months ago

Description

Microsalt cases are stuck on "Running" in statusdb which is causing them to not store in housekeeper.

Suggested solution

Set cases to "Empty" in statusdb when they have completed in trailblazer.

This can be closed when

Cases are stored in housekeeper again.

Blocked by

Nothing

Vince-janv commented 10 months ago

Decision

SofiaOtero commented 10 months ago

It is not possible to store the current cases as we get an issue with the negative control samples in the cases:

Error storing deliverables for case <case_name> - /home/proj/production/microbial/results//<sample_id>_2023.9.20_1.9.31/<sample_id>/assembly/quast/<sample_id>_report.tsv

Has something changed with handling negative controls for microsalt?

Vince-janv commented 10 months ago

It is not possible to store the current cases as we get an issue with the negative control samples in the cases:

Error storing deliverables for case <case_name> - /home/proj/production/microbial/results//<sample_id>_2023.9.20_1.9.31/<sample_id>/assembly/quast/<sample_id>_report.tsv

Has something changed with handling negative controls for microsalt?

Hmm, I think the actions we decided upon will not solve the root issue. Will need to look a bit deeper at this

Vince-janv commented 10 months ago

Bug found

The remove_missing_files validator method of CGDeliverables is not working properly. It is suposed to remove non-mandatory files if they are missing. This is not done, and hence an error is thrown when trying to store them in housekeeper.

@islean Could you work on a patch tomorrow? I have an example file I can show you.

islean commented 10 months ago

Command has been run and succeeded after the merging of #2522.