Clinical-Genomics / cg

Glue between Clinical Genomics apps
8 stars 2 forks source link

Ensure data for negative controls is delivered to customers #2871

Open karlnyr opened 7 months ago

karlnyr commented 7 months ago

Description

Negative controls require all reads linked to their housekeeper bundle and have the read counts added to the sample in statusdb and LIMS.

Suggested solution

When we parse the demultiplexing stats we do get the number of reads from the sample, the next step would be to (a) check if a sample is a negative control or (b) find the metagenomic negative control on a flow cell, and handle it differently.

This can be closed when

Negative controls have their reads added to the sample bundle, statusdb, and LIMS disregarding read quality.

Clarification

Negative controls by definition won't pass our QC after sequencing and won't have the fastq files linked to them. Negative controls should always have their data transferred. These can be used by the customer to filter out any noise from the prep. Also, in the new metagenomic analyses they are needed.

  1. Negative controls do not pass sequencing QC
  2. Negative controls fastq are not stored in their respective housekeeper sample bundle
  3. Negative control samples are not added or updated in status db in the IlluminaSampleSequencingMetrics table.
  4. Negative control samples need to be added to LIMS.

The above four steps are required to pass.

Second Clarification

karlnyr commented 7 months ago

Discussion

Decision

karlnyr commented 7 months ago

Plan is to analyse eternaltahr with its negative control ACC9713A25 which has reads and of low quality, requesting flow cell HVNHGDSX2 to fetch the data back to hasta so that we can add it to ACC9713A25 temporarily.

beatrizsavinhas commented 2 months ago
karlnyr commented 1 month ago

Analysis completed without any issues. This means that we can now begin the process of adding data for all negative controls to hk as well! @Clinical-Genomics/sysdev, could you prioritize this? The current situation is very prone to mistakes, and the metagenomic samples are quite time-sensitive.

diitaz93 commented 1 month ago

Technical refinement

Questions

karlnyr commented 1 month ago

It is not pipeline relevant. This is on an organisation level where we would like to store all reads for samples that are negative controls @diitaz93

Vince-janv commented 1 month ago

@karlnyr What issue would this resolve? Is it a requirement for taxprofiler being implemented in production?

karlnyr commented 1 month ago

This would resolve two things:

karlnyr commented 1 month ago

Edited issue, as this would be changed for all negative controls, not specifically for metagenomic ones.

Vince-janv commented 1 month ago

Technical Refinement

beatrizsavinhas commented 1 week ago

Changes reverted.

Blocked until the changes can be implemented in LIMS.