The function from the old post-processing was copied and pasted to the new flow, considering that the old function will be removed. The intermediate functions used to handle the HK API defined in cg/meta/demultiplex/housekeeper_storage_functions.py were not moved to a new utils module, this is left for another PR where a better refactoring is done to these methods.
Added
Method store_illumina_data_in_housekeeper in IlluminaPostProcessingService.
Changed
Renamed method store_illumina_flow_cell_data to store_illumina_data_in_status_db for clarity
Fixed
-
How to prepare for test
No endpoint, changes will be tested when new post-processing is validated
Review
[x] "Merge and deploy" approved by CO
Thanks for filling in who performed the code review and the test!
[x] PATCH - when you make backwards compatible bug fixes or documentation/instructions
Implementation Plan
[x] Deployed to stage:
INFO [alembic.runtime.migration] Context impl MySQLImpl.
INFO [alembic.runtime.migration] Will assume non-transactional DDL.
fatal: Not a git repository (or any parent up to mount point /home)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
repository is clean
Logging deploy ...
Getting deployer... done.
Getting last commit message and SHA... done.
Getting version of deploy scripts... /home/js.diazboada
done.
Log deploy... done.
cg, version 61.1.6
[js.diazboada@hasta:~] [S_base] $ up
Description
Closes https://github.com/Clinical-Genomics/add-new-tech/issues/24. Implement storage of Illumina demultiplexing files (fastq files, demux logs, and run parameters files) in the Illumina post-processing service.
The function from the old post-processing was copied and pasted to the new flow, considering that the old function will be removed. The intermediate functions used to handle the HK API defined in
cg/meta/demultiplex/housekeeper_storage_functions.py
were not moved to a new utils module, this is left for another PR where a better refactoring is done to these methods.Added
store_illumina_data_in_housekeeper
inIlluminaPostProcessingService
.Changed
store_illumina_flow_cell_data
tostore_illumina_data_in_status_db
for clarityFixed
-
How to prepare for test
No endpoint, changes will be tested when new post-processing is validated
Review
This version is a
Implementation Plan