Clinical-Genomics / cg

Glue between Clinical Genomics apps
8 stars 2 forks source link

Create orderflow for microbial sequencing only #3338

Open Vince-janv opened 3 months ago

Vince-janv commented 3 months ago

Description

For human DNA samples customers can order different analysis workflow but they can also order sequencing only (FASTQ) where we just send them the FASTQ files.

This option does not exist for microbial samples where only a microSALT analyses are available and require input parameters which the customers might not have.

Acceptance Criteria

Notes

Implementation plan

ChrOertlin commented 3 months ago

@Vince-janv does this issue need a technical refinement? If not we should add it to the trocadero "ready" column. Otherwise we have to add it to the refinement meeting.

Vince-janv commented 3 months ago

@Vince-janv does this issue need a technical refinement? If not we should add it to the trocadero "ready" column. Otherwise we have to add it to the refinement meeting.

I will call relevant people to refinement and put it in the ready column when finished

annagellerbring commented 3 months ago

Lab UDFs in new workflow: (in discussion with @FayKanellidou)

Keep:

Remove:

FYI @annaengstrom @AnnaZetterlund

Vince-janv commented 1 month ago

Technical Refinement

FE

BE

ChrOertlin commented 2 weeks ago

Backend solutions are in place now. Waiting on FE implementaiton to test.

ChrOertlin commented 1 week ago

@Vince-janv What are the fields that need to be displayed on the front end. @moedarrah and I are testing and we run into issues with validation errors when fields become hidden on the fornt end.

For example when putting no container then the volume disappears which is required when putting a microbial fastq order

moedarrah commented 1 week ago

An error will occur if we don't specify the "Volume (μL)", which will be hidden when "No Container" is selected. Image

Image

diitaz93 commented 1 week ago

@Vince-janv

Vince-janv commented 1 week ago

@Vince-janv What are the fields that need to be displayed on the front end. @moedarrah and I are testing and we run into issues with validation errors when fields become hidden on the fornt end.

For example when putting no container then the volume disappears which is required when putting a microbial fastq order

@moedarrah Was Volume the only field? I looked into it and the same bug is present for the exists in the current microbial workflow in production. I'm in contact with prod whether to disallow No container for both or allow it for both (and fix the bug)

Vince-janv commented 1 week ago

After discussion with KN we decided that for both the existing microbial flow and for this one, the option No-container should not be available. @moedarrah Not sure what the best way to implement this is. If it is a hassle in the front-end we can sit down and refine it a bit

moedarrah commented 1 week ago

@Vince-janv For the front end, there is no issue. We just need to ensure that the backend accepts the order without requiring the 'Volume (μL)' field.

Vince-janv commented 1 week ago

@moedarrah It's rather the countrary, we always want to receive the volume for these so the option No-container should not be available (ie the option that hides the volume field)