fix(clean flow cell api) - Githubissues

Clinical-Genomics / cg

Glue between Clinical Genomics apps

6 stars 2 forks source link

fix(clean flow cell api) #3354

Closed ChrOertlin closed 1 week ago

ChrOertlin commented 1 week ago

Description

Part of the project to implement new run devices. This PR addresses refactoring of the clean flow cells api. Closes: https://github.com/Clinical-Genomics/add-new-tech/issues/29

Changed

Changed cli command cg clean flow-cells to cg clean sequencing-runs
Renamed CleanFlowCellApi to IlluminaCleanSequencingRunsService
Moved files related to the serves into cg/services/illumina_services/illumina_cleaning_services
Moved testing suite into approriate places

Fixed

-

How to prepare for test

[ ] Ssh to relevant server (depending on type of change)
[ ] Use stage: us
[ ] Paxa the environment: paxa

[ ] Install on stage (example for Hasta):

bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

[ ] Do ...

Expected test outcome

[ ] Check that ...
[ ] Take a screenshot and attach or copy/paste the output.

Review

[ ] Tests executed by
[ ] "Merge and deploy" approved by Thanks for filling in who performed the code review and the test!

This version is a

[ ] MAJOR - when you make incompatible API changes
[ ] MINOR - when you add functionality in a backwards compatible manner
[ ] PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

[ ] Document in ...
[ ] Deploy this branch on ...
[ ] Inform to ...

sonarcloud[bot] commented 1 week ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud