refactor(Flow cell encryption) - Githubissues

Clinical-Genomics / cg

Glue between Clinical Genomics apps

8 stars 2 forks source link

refactor(Flow cell encryption) #3358

Closed ChrOertlin closed 3 months ago

ChrOertlin commented 3 months ago

Description

Refactor the flow cell encryption api.

Added

-

Changed

Renamed FlowCellEncryptionAPI to IlluminaRunEncryptionService
Moved IlluminaRunEncryptionService` tocg/services/illumina_services/backup_services/encryption_services
Move encryption fixtures to a dedicated fixute plugin file
Moved and refactored tests of the ``IlluminaRunEncryptionService
Renamend cli command cg encrypt flow-cells to cg encrypt illumina-runs

Fixed

-

How to prepare for test

[ ] Ssh to relevant server (depending on type of change)
[ ] Use stage: us
[ ] Paxa the environment: paxa

[ ] Install on stage (example for Hasta):

bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

[ ] Do ...

Expected test outcome

[ ] Check that ...
[ ] Take a screenshot and attach or copy/paste the output.

Review

[ ] Tests executed by
[ ] "Merge and deploy" approved by Thanks for filling in who performed the code review and the test!

This version is a

[ ] MAJOR - when you make incompatible API changes
[ ] MINOR - when you add functionality in a backwards compatible manner
[ ] PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

[ ] Document in ...
[ ] Deploy this branch on ...
[ ] Inform to ...

sonarcloud[bot] commented 3 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

ChrOertlin commented 3 months ago

Nice 👍 As with the previous PR I assume no logic has been touched?

Apart from the renaming, no.