rework(backup) - Githubissues

Clinical-Genomics / cg

Glue between Clinical Genomics apps

8 stars 2 forks source link

rework(backup) #3360

Closed ChrOertlin closed 3 months ago

ChrOertlin commented 3 months ago

Description

Rewiring of the backup service to make use of the new illumina related database models.

Closes: https://github.com/Clinical-Genomics/add-new-tech/issues/31

Added

Changed

CLI command cg backup flow-cell renamed to cg backup illumina-runs
CLI command cg backup fetch-flow-cell renamed to cg backup fetch-illumina-run
Rewired backup logic to make used of IlluminaSequencingRun table instead of FlowCell table.

Fixed

-

How to prepare for test

[ ] Ssh to relevant server (depending on type of change)
[ ] Use stage: us
[ ] Paxa the environment: paxa

[ ] Install on stage (example for Hasta):

bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

[ ] Do ...

Expected test outcome

[ ] Check that ...
[ ] Take a screenshot and attach or copy/paste the output.

Review

[ ] Tests executed by
[ ] "Merge and deploy" approved by Thanks for filling in who performed the code review and the test!

This version is a

[ ] MAJOR - when you make incompatible API changes
[ ] MINOR - when you add functionality in a backwards compatible manner
[ ] PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

[ ] Document in ...
[ ] Deploy this branch on ...
[ ] Inform to ...

sonarcloud[bot] commented 3 months ago

Quality Gate failed

Failed conditions
3.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

ChrOertlin commented 3 months ago

Ignoring code duplication in tests