search

Clinical-Genomics / cg_lims

3 stars 1 forks source link

depricate calculate_amount.py #116

Closed mayabrandi closed 2 years ago

mayabrandi commented 2 years ago

This script is being used in

Protocol: Initial QC Microbial v3 step CG002 - Quantit QC (DNA). Button: 2. Calculate Amount

Protocol: Library validation QC wgs v3. Step CG002 - Qubit QC (Library Validation) Button: Prehyb QC - Calc Amount and Assign QC Flagg

It should be replaced by https://github.com/Clinical-Genomics/cg_lims/blob/master/cg_lims/EPPs/udf/calculate/calculate_amount_ng.py.

But it must have remove 3 as argument.

barrystokman commented 2 years ago

PR https://github.com/Clinical-Genomics/cg_lims/pull/117 has been deployed using 0 instead of 3, as requested

AnnaLeinfelt commented 2 years ago

Is this done?

barrystokman commented 2 years ago

@AnnaLeinfelt Yes. The old EPP has been replaced and is not in use anymore. PR to archive that EPP here: https://github.com/Clinical-Genomics/clinical_EPPs/pull/226.

mayabrandi commented 2 years ago

Can you close this one @barrystokman if its all done?

barrystokman commented 2 years ago

@mayabrandi Can you approve https://github.com/Clinical-Genomics/clinical_EPPs/pull/226 so I can merge it? After that I'll close this issue.

barrystokman commented 2 years ago

All PRs merged, closing