Avoid crash when user provides non-integer gene IDs in the report endpoint - Githubissues

Clinical-Genomics / chanjo-report

Report generator for Chanjo output

MIT License

0 stars 0 forks source link

Avoid crash when user provides non-integer gene IDs in the report endpoint #27

Closed northwestwitch closed 2 years ago

northwestwitch commented 2 years ago

This PR adds | fixes:

Fix #26

How to reproduce the bug

[x] Setup a demo db using the following command: make setup
[x] Create a report with the command: make report
[x] Go to the report page: http://localhost:5000/report?sample_id=sample1&sample_id=sample2&sample_id=sample3
[x] Search for coverage in gene with ID that is not valid (non- numerical), for instance add this the link above &gene_ids=gene1,gene2,etc

How to test:

[x] Switch to this. branch and repeat the above (after removing the chanjo-report containers and dangling images)
[x] The error above shouldn't occur, and a red error message should be printed on the report instead

Review:

[x] Code approved by DN
[x] Tests executed by DN, CR

This version is a:

[ ] MAJOR - when you make incompatible API changes
[ ] MINOR - when you add functionality in a backwards compatible manner
[x] PATCH - when you make backwards compatible bug fixes or documentation/instructions

northwestwitch commented 2 years ago

Master branch: ⛔

This branch: 🆗