Fixed LocalStack.__ident_func__ missing error - Githubissues

Clinical-Genomics / chanjo-report

Report generator for Chanjo output

MIT License

0 stars 0 forks source link

Fixed LocalStack.__ident_func__ missing error #32

Closed northwestwitch closed 2 years ago

northwestwitch commented 2 years ago

This PR adds | fixes:

Simpler way of installing required libs
Fix #31 by writing a custom Alchy class with the error fixed instead of importing and using the class from Flask-Alchy

How to prepare for test:

Remove all chanjo and chanjo-report Docker images (run docker system prune after removing stuff from docker interface)

How to test:

Run:

make setup
make report

Expected outcome:

HTML report should show with no errors --> http://localhost:5000/report?sample_id=sample1&sample_id=sample2&sample_id=sample3

Review:

[ ] Code approved by
[ ] Tests executed by
[ ] "Merge and deploy" approved by

This version is a:

[ ] MAJOR - when you make incompatible API changes
[ ] MINOR - when you add functionality in a backwards compatible manner
[x] PATCH - when you make backwards compatible bug fixes or documentation/instructions

northwestwitch commented 2 years ago

Super! A little reading later I still dont understand why e.g. threading.get_ident() wouldn't do the trick instead of greenlet, but, hey, the latter looks nice and really well maintained. I would also not be surprised if it made into the standard library before long.

Exactly, I've changed it to use the threading!

northwestwitch commented 2 years ago

Thanks for the review @dnil, I'm merging now!