Clinical-Genomics / clinical_EPPs

EPPs used in clinical genomics LIMS
3 stars 0 forks source link

Modify calculation for Genotyping workflow #125

Closed annaengstrom closed 4 years ago

annaengstrom commented 4 years ago

Lims Issue

Work Flow: CG001 - Genotyping Protocol: CG002 - Genotyping Step: CG002 - Plate Setup MAF

Description: We would like to to modify the calculations of the script. Instead of having a fixed final volume, we would like to have a fixed sample volume.

Basic requirement from MAF in Hudding: MAF requirements: 4 ng/ul final concentration of sample in minimum 15 ul volume, no maximum volume.

Script details:

-> 20-244 ng/ul: sample volume 3 ul -> 244-364 ng/ul: sample volume 2 ul -> 364-724 ng/ul: sample volume 1 ul -> 724-1444 ng/ul: sample volume 0.5 ul

annaengstrom commented 4 years ago

We can discuss this more in detail, and I can explain more clearly when we meet next week

mayabrandi commented 4 years ago

We have gone through this today, and I have updated the scripts. I will deploy them in production as soon as you have finished the samples you are working on atm @annaengstrom . Let we know when you are don. Then we can close this issue.

annaengstrom commented 4 years ago

Done.

mayabrandi commented 4 years ago

I have updated production with the updated scripts. Closing this issue now

annaengstrom commented 4 years ago

Two things missing in production view:

annaengstrom commented 4 years ago

Two things missing in production view:

  • [ ] QC flags
  • [ ] script to create csv file for water volume only (should be the same for the microbial workflow). One file per plate.

Has this been fixed @mayabrandi ?

mayabrandi commented 4 years ago

I will open a separate issue for this @annaengstrom. I need a minute of your time to specify what the csv should look like.

annaengstrom commented 4 years ago

I have used the script, CSV file works fine, but calculations for sample concentrations below 5 ng/ul does not seem to be correct. Since the minimum concentration needed is 4 ul, the script should give an output of no value at all for samples with a concentration below 4 ng/ul (and should color those squares red in the sample placement map), but it seems 5 is a limit? A concentration of 4 and over is actually fine for this step, but when I try concentrations below 5, the calculations does not seems to be correct.

mayabrandi commented 4 years ago

Lets look at it together tomorrow?

20 feb. 2020 kl. 14:53 skrev Anna Lyander notifications@github.com:

I have used the script, CSV file works fine, but calculations for sample concentrations below 5 ng/ul does not seem to be correct. Since the minimum concentration needed is 4 ul, the script should give an output of no value at all for samples with a concentration below 4 ng/ul (and should color those squares red in the sample placement map), but it seems 5 is a limit? A concentration of 4 and over is actually fine for this step, but when I try concentrations below 5, the calculations does not seems to be correct.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/Clinical-Genomics/clinical_EPPs/issues/125?email_source=notifications&email_token=AAJ65XO7TFJBCCRQW5MZ3MDRD2DMFA5CNFSM4KHTOHM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMOALQA#issuecomment-589039040, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJ65XJGIFN2LSKSABBIUMTRD2DMFANCNFSM4KHTOHMQ.

annaengstrom commented 4 years ago

Are the last steps deployed in production?

annaengstrom commented 4 years ago

Done.