search

Clinical-Genomics / demultiplexing

To keep scripts associated with execution of the Illumina demultiplexing pipeline
5 stars 0 forks source link

Feat/indexreport #126

Closed karlnyr closed 3 years ago

karlnyr commented 3 years ago

To be added in this PR:

Adds a summary of the index report, extracting the most important information and placing it in a more convenient path for the user reading it.

How to prepare for test:

How to test:

Expected test outcome:

Review:

This version is a:

karlnyr commented 3 years ago

@henrikstranneheim I have now reformatted the code a lot. Using more typing and return types.

karlnyr commented 3 years ago

Installing the branch on stage: image

Options for the module: image

Running a dry-run: image

Running on a S4: image

karlnyr commented 3 years ago

@barrystokman can you give this a final look and maybe we could merge it?

barrystokman commented 3 years ago

image

Please never test on production data!

karlnyr commented 3 years ago

@barrystokman Does this seem okay to you now? D you want me to re-do the test on stage data instead?

barrystokman commented 3 years ago

@karlnyr changes approved, go ahead and merge/bump/deploy! edit: no need to retest with stage data.

moonso commented 3 years ago

It's merged!! tenor

henrikstranneheim commented 3 years ago

@karlnyr Do not forget to post a picture of the deployment that was done

karlnyr commented 3 years ago

What if I told you @henrikstranneheim that it was already deployed yesterday and that I forgot that I had to do this procedure 🙃

henrikstranneheim commented 3 years ago

tenor

henrikstranneheim commented 3 years ago

No seriously. I trust you when you say you have deployed it.

henrikstranneheim commented 3 years ago

Just try to add it next time 😄

karlnyr commented 3 years ago

Great! Yea, totally slipped my mind this time. 👍

henrikstranneheim commented 3 years ago

No worries 👍