Clinical-Genomics / demultiplexing

To keep scripts associated with execution of the Illumina demultiplexing pipeline
5 stars 0 forks source link

Add Y to base mask #154

Closed moahaegglund closed 3 years ago

moahaegglund commented 3 years ago

Updating the base mask as we get an error message in demultiplexing right now: "UseBasesMask formatting error. Use base mask must start with either a 'y', 'i', or 'n'. Use base mask: '151'".

How to prepare for test:

How to test:

Expected test outcome:

Review:

This version is a:

moahaegglund commented 3 years ago

Tests executed, Screenshot 2021-05-27 at 12 25 33

barrystokman commented 3 years ago

This was PR was made and approved today and not merged and deployed yet

karlnyr commented 3 years ago

This was PR was made and approved today and not merged and deployed yet

No but I recall having a conversation with you @barrystokman regarding this very "Y" that was missing for some odd reason(not very odd, I removed it in https://github.com/Clinical-Genomics/demultiplexing/pull/152). Anyways, good that you solved it @moahaegglund !

moahaegglund commented 3 years ago

@barrystokman can you merge this so that we get the demux of HiSeqX to work?

barrystokman commented 3 years ago

Bumped: image

Deployed: image

moahaegglund commented 3 years ago

Thanks! :D