Closed patrikgrenfeldt closed 5 years ago
Test result:
π
Test result demux:
π
π
Test result check for new demux:
π
put both files through a linter :)
Code looks good! Feel free to approve in my name when tests are completed and the version bump is motivated
Approving M&D :rocket:
Just wondering as this is also renaming the fastq files, did you check if the fastq filenames were sane?
Just wondering as this is also renaming the fastq files, did you check if the fastq filenames were sane?
No we did not. What should the names be? How do we know they are correct?
@emiliaol are we even using the fastq files for something afterwards or are we only demuxing to get the statistics? If the latter, we can drop the fastq renaming code.
eeh, let's just leave the code in for now. I'm unsure if cgstats is using the restructured dir or not.
deployed
This PR adds demuliplexing support for iSeq
How to setup:
bash servers/resources/clinical-preproc.scilifelab.se/update-demux-stage.sh Automatic-demultiplexing-of-iSeq-runs
How to test demultiplexing:
bash demux-iseq.bash /home/hiseq.clinical/iseq/runs/20190528_FS10000534_7_BPC29611-3324/ /home/hiseq.clinical/iseq/demux/
Expected outcome:
How to test checking for new run:
bash checkfornewrun.bash /home/hiseq.clinical/iseq/runs/ /home/hiseq.clinical/iseq/demux/
Expected outcome:
demuxstarted.txt
file should start. All other should be mentioned as already demultiplexed.Take a screenshot and attach or copy/paste the output.
Review:
This is |minor| version bump because we add func without altering the old one