Clinical-Genomics / demultiplexing

To keep scripts associated with execution of the Illumina demultiplexing pipeline
5 stars 0 forks source link

Automatic demultiplexing of iseq runs #91

Closed patrikgrenfeldt closed 5 years ago

patrikgrenfeldt commented 5 years ago

This PR adds demuliplexing support for iSeq

How to setup:

  1. install on stage of thalamus: bash servers/resources/clinical-preproc.scilifelab.se/update-demux-stage.sh Automatic-demultiplexing-of-iSeq-runs
  2. cd cd /home/hiseq.clinical/SCRIPTS/git/demultiplexing/
  3. git pull
  4. git checkout Automatic-demultiplexing-of-iSeq-runs
  5. activate stage: source activate stage
  6. cd /home/hiseq.clinical/SCRIPTS/git/demultiplexing/scripts/iseq/

How to test demultiplexing:

  1. run following command: bash demux-iseq.bash /home/hiseq.clinical/iseq/runs/20190528_FS10000534_7_BPC29611-3324/ /home/hiseq.clinical/iseq/demux/

Expected outcome:

How to test checking for new run:

  1. run following command: bash checkfornewrun.bash /home/hiseq.clinical/iseq/runs/ /home/hiseq.clinical/iseq/demux/

Expected outcome:

Take a screenshot and attach or copy/paste the output.

Review:

This is |minor| version bump because we add func without altering the old one

patrikgrenfeldt commented 5 years ago

Test result: image

πŸ‘Ž

patrikgrenfeldt commented 5 years ago

Test result demux: image

πŸ‘

image πŸ‘Ž

patrikgrenfeldt commented 5 years ago

Test result check for new demux: image

πŸ‘

ingkebil commented 5 years ago

put both files through a linter :)

ingkebil commented 5 years ago

Code looks good! Feel free to approve in my name when tests are completed and the version bump is motivated

ingkebil commented 5 years ago

Approving M&D :rocket:

ingkebil commented 5 years ago

Just wondering as this is also renaming the fastq files, did you check if the fastq filenames were sane?

patrikgrenfeldt commented 5 years ago

Just wondering as this is also renaming the fastq files, did you check if the fastq filenames were sane?

No we did not. What should the names be? How do we know they are correct?

ingkebil commented 5 years ago

@emiliaol are we even using the fastq files for something afterwards or are we only demuxing to get the statistics? If the latter, we can drop the fastq renaming code.

ingkebil commented 5 years ago

eeh, let's just leave the code in for now. I'm unsure if cgstats is using the restructured dir or not.

ingkebil commented 5 years ago

deployed