iseq sample sheet: index2 is reverse complement of index2 found in LIMS

barrystokman commented 5 years ago

This PR makes sure the iSeq sample sheet is formatted correctly.

This PR solves https://github.com/Clinical-Genomics/demultiplexing/issues/90

How to test:

install on stage of thalamus: bash /home/hiseq.clinical/servers/resources/clinical-preproc.scilifelab.se/update-demux-stage.sh iseq-sample-sheet
activate stage: source activate stage
run following command: demux sheet fetch -a iseq -p --longest BPC29611-3324

Expected outcome: The sample sheet should be printed to the terminal, and index2 of Sample_ID ACC5726A1 should read ACACTAAGGT instead of ACCTTAGTGT

Review:

[x] code approved by @ingkebil
[x] tests executed by @barrystokman
[x] "Merge and deploy" approved by @ingkebil Thanks for filling in who performed the code review and the test!

This is minor version bump because it's a backwards compatible change

ingkebil commented 5 years ago

Oh, just saw this was still a draft. Well, so far so good! :+1:

barrystokman commented 5 years ago

:heavy_check_mark:

ingkebil commented 5 years ago

Approved!

ingkebil commented 5 years ago

hehe, nice catch :)

barrystokman commented 5 years ago

it was only there for 5 months haha

barrystokman commented 5 years ago

By request of @emiliaol and @patrikgrenfeldt I added fcid to the sample sheet, tests are still ok:

Clinical-Genomics / demultiplexing

iseq sample sheet: index2 is reverse complement of index2 found in LIMS #92