Clinical-Genomics / genmod

Annotate models of genetic inheritance patterns in variant files (vcf files)
http://Clinical-Genomics.github.io/genmod/
MIT License
78 stars 19 forks source link

Compound scoring: Cap rankscore values to (min, ) range #110

Closed torbjorgen closed 1 year ago

torbjorgen commented 1 year ago

Capping of rank score bounds fix.

See code comments and READMEs for details on the issue.

TL;DR: When rank score is modified in compound scoring step, the score might fall outside the min-max bounds determined in the variant scoring step (on the lower end). Any such rank score is an invalid value, since it won't map well into the normalized range. Therefore, cap any such low rank score value to (min, max) range.

This impacts the existing rank rank scoring behavior and differs from previous patches on this subject

Opening this PR to make this change visible.

This PR adds | fixes:

How to prepare for test:

How to test:

-

Expected outcome:

Review:

This version is a:

torbjorgen commented 1 year ago

ping @henrikstranneheim @Vince-janv @jemten @dnil Thanks!