"record_rule = max" appears to prioritize based on max(value) rather than max(score)

Clinical-Genomics / genmod

Annotate models of genetic inheritance patterns in variant files (vcf files)

http://moonso.github.io/genmod/

MIT License

74 stars 18 forks source link

Open bjhall opened 6 years ago

bjhall commented 6 years ago

At least for "data_type = integer", not sure about float and string.

Minimal test vcf and rank model for testing (had to name them *.txt for github to allow them to be uploaded):

If I run: $ genmod score -i test -c minimal_rankmodel.ini.txt -r minimal.vcf.txt -o minimal.score

I get "RankResult=1" (from value 5) whereas I would expect it to be 100 (from value 4).

Same problem with "record_rule = min" btw.

bjhall commented 6 years ago

obviously it doesn't affect data_type=string since it has no "value"