Closed ChrOertlin closed 8 months ago
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
Nice! Next step could be to add a service layer to further decouple the database layer from the api layer.
api layer (parse json to dto) -> service layer -> database layer (database records) -> service layer (convert database records to dto) -> api layer (serialize dto to json).
Could make it simpler to decouple the dtos and database models. This is FastAPI though, seems like some of it is built in already
Yes, SQLModel is made to directly translate database models to DTOs for FastAPI. But we would like to detangle the CRUD and the API and remove SQLmodel. So we will implement the structure you outlined here for genotype as well! That way it is the same as in our other repos, and to me much clearer to work with.
Added
Move database statements out of analysis api
Changed
Fixed
Steps to consider while deploying
Review:
This version is a: